battery_level vs. usable_battery_level #321

[ctraber]

As a first step I added usable_battery_level to positions table and summary page.

Sorry, but I'm not familiar with the Elixir yet and I'm sure there are still things missing (translation, test,?)...

[ctraber]

Tests passing on my dev env now.

Here I get:
12:49:44.528 [error] Postgrex.Protocol (#PID<0.1069.0>) disconnected: ** (DBConnection.ConnectionError) owner #PID<0.3853.0> exited

[adriankumpf]

Does it make sense to hide the 'Usable State of Charge' row if usable_battery_level == battery_level? What do you think?

[ctraber]

Sure makes sense. There is no additional information when both are the same.
I'll also try to make a snowflake when difference is higher than 2% I think thats what the TeslaApp does.

[adriankumpf]

I'll also try to make a snowflake when difference is higher than 2% I think thats what the TeslaApp does.

Yeah, that would be great!

[adriankumpf]

Looks really good! After rerunning the tests everything passes :)

[ctraber]

How can you restart the test without commit? Just in case i happens again.

[adriankumpf]

There is a "restart build" button on the Travis page. But I'm not sure if it allows you to do that. Ideally, it shouldn't be required to rerun that often. Some tests are sensitive to timing though and therefore can be flaky.

[adriankumpf]

Excellent. Will merge soon!

[ctraber]

Finally it was cold enough for a snowflake. By using usable_battery_level, the projected range is not changing that much with temperature. I think it gives a better degradation overview.

[adriankumpf]

It took a little longer, but I could finally take a closer look at the PR. I made a just few adjustments:

• Replaced the existing degradation dashboard with your 'projected range' dashboard
• Moved the "(xxx km 100%)" text into a tooltip
• Added a test for the snowflake icon

Thanks again! :)

[adriankumpf]

Resolves #321

[ctraber]

Will I see the tooltip in iOS Safari?
Most of the time I view it on my phone.

[adriankumpf]

Should work with 3904a18

[ctraber]

Thanks a lot!
Just tried. Works perfectly.

[ctraber]

I tested your new projected range dashboard.
In the second panel the coalesce for usable_battery_level is missing. I would add it but for some reason I do not get the dashboard, I changed in filesystem, after building a new grafana image.

Do you have an idea why it is not showing the changed dashboard after docker build and restart of container?

[adriankumpf]

You are referring to the following query (line 3), right?

SELECT
	$__timeGroup(date, '6h') AS time,
	convert_km(sum([[preferred_range]]_battery_range_km) / sum(usable_battery_level) * 100, '$length_unit') AS "Projected Range (using usable_battery_level) [$length_unit]",
	convert_km(sum([[preferred_range]]_battery_range_km) / sum(battery_level) * 100, '$length_unit') AS "Projected Range (using battery_level) [$length_unit]"
FROM
	positions
WHERE
	$__timeFilter(date) and
	car_id = $car_id
GROUP BY
	1
ORDER BY
	1,2  DESC

I don't see why sum(coalesce(usable_battery_level,battery_level)) should be necessary. Could you explain that?

Do you have an idea why it is not showing the changed dashboard after docker build and restart of container?

Does it show up if you add the dashboard under a new name (and with a different uid)?

[ctraber]

The null values mess up the graph at the point where database starts having values for usable_battera_level. Maybe sum() with some null values, not sure.

see the spike with app. 1700 km.

I can add new dashboards.
But, I copied yours with "save as" changed it and copied the json to the existing file, changed names... But if I re-build the container its again your previous version..
=> changing in file, build... and still the version before file change.

[adriankumpf]

Hmm, seems to work fine for me. Anyway, if coalesce helps, let's add it back in.

But, I copied yours with "save as" changed it and copied the json to the existing file, changed names... But if I re-build the container its again your previous version..
=> changing in file, build... and still the version before file change.

Very strange. Sounds like it takes the previous file when creating the image? Maybe try doing the following:

1. Stop the container
2. delete the grafana volume
3. build the image
4. run the new image

[ctraber]

Deleting the volume did the trick.
Thanks!