Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF: move warm_start to __init__ #54

Closed
adriangb opened this issue Aug 14, 2020 · 1 comment
Closed

REF: move warm_start to __init__ #54

adriangb opened this issue Aug 14, 2020 · 1 comment

Comments

@adriangb
Copy link
Owner

Mirrors scikit-learn estimators: https://github.com/scikit-learn/scikit-learn/blob/0fb307bf3/sklearn/linear_model/_stochastic_gradient.py

It probably makes sense to make a _fit method, which will also help accommodate the use of epochs (which should always be 1 for partial_fit).
@adriangb
Copy link
Owner Author

Closing as this was implemented in #67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adriangb