enable hardened runtime support for macos #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karianna
added
the
enhancement
|
Have you seen the work of Simon Tooke regarding this issue for the openjdk project? |
We're working directly with him :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to bundle AdoptOpenJDK binaries into notarized macOS applications.
This is confirmed to be fixed on JDK11+
On JDK8 we still hit the same issue that the Corretto folks do which is this error:
My suggestion would be that we investigate shipping a JDK8 build that is optimized for bundling (i.e built on a later toolchain) This repo may be usefil as it contains some patches required to get JDK8 to compile on xcode10.
partially resolves: #1130