Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MarketPlace data binary.package.sha265sum name incorrect #542

Open
andrew-m-leonard opened this issue Nov 8, 2024 · 3 comments
Open

MarketPlace data binary.package.sha265sum name incorrect #542

andrew-m-leonard opened this issue Nov 8, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@andrew-m-leonard
Copy link

binary.package.sha265sum should be sha256sum

Currently the Asset definition and numerous examples and code use the same typo: https://github.com/search?q=org%3Aadoptium%20sha265sum&type=code

Some vendors have assumed the correct spelling, eg. https://github.com/rh-openjdk/marketplace/blob/8a48a422ad38b5af4fafb51c72ea001ed17eb895/21/jdk_21_0_5.json#L30

@andrew-m-leonard andrew-m-leonard added the bug Something isn't working label Nov 8, 2024
@andrew-m-leonard
Copy link
Author

Explains why Checksum field is blank in the marketplace for Red Hat and Microsoft: https://adoptium.net/marketplace/?version=21&os=linux&arch=x64,

@tellison
Copy link
Contributor

@johnoliver unless you have other ideas, it seems that 'fixing' this field name will break some vendors' existing data - so we can either (a) co-ordinate with vendors and push a fix at the same time vendors regenerate/resign their information, or (b) support the wrong and correct field name for a limited time to allow transition.

@johnoliver
Copy link
Contributor

Yes we unfortunately need to support both to avoid an API breaking change, done a PR at:

#553

Unfortunately this goes beyond just the vendors, the public API also had the typo so needs to be supported for backwards compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants