-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude known problematic tests #3611
Conversation
Signed-off-by: Sophia Guo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @sophia-guo - LGTM, if you are just excluding this single test under this PR, then suggest changing the title to "Exclude TestInstrumentation test on linux-all" as it makes it easier to understand what it was about by simply looking at the title in the list of closed PRs instead of having to inspect the contents.
@smlambert agreed, I was going to exclude multiple known issues. Maybe I should convert it to Draft first. |
some more to add (related: #3603): java/lang/instrument/BootClassPath/BootClassPathTest.sh https://bugs.openjdk.java.net/browse/JDK-8256405 macosx-all For jdk8 and jdk11: |
Currently we probably don't have an easy way to exclude specific tests for alpine-linux? |
re: #3611 (comment) perhaps as a temporary solution, while we figure out if there is a way to do it upstream ... create a single file called ProblemList_alpine-linux.txt that gets appended to commandline with logic in openjdk.mk ? Use that file for all versions, because so far, the issues we are seeing affect all versions, and also as it would be temporary, until a more solid approach could be done. |
@sophia-guo please ignore the alpine-linux one for now ... it would be good to get this merged and backported to v0.9.1-release as vendors need the updates to prepare for marketplace (and it would help when finishing up release triage not to keep running tests that fail for known reasons). |
Signed-off-by: Sophia Guo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Close #3605
Close #3573
Signed-off-by: Sophia Guo [email protected]