Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude known problematic tests #3611

Merged
merged 3 commits into from
May 4, 2022
Merged

Exclude known problematic tests #3611

merged 3 commits into from
May 4, 2022

Conversation

sophia-guo
Copy link
Contributor

@sophia-guo sophia-guo commented Apr 26, 2022

Close #3605
Close #3573

Signed-off-by: Sophia Guo [email protected]

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @sophia-guo - LGTM, if you are just excluding this single test under this PR, then suggest changing the title to "Exclude TestInstrumentation test on linux-all" as it makes it easier to understand what it was about by simply looking at the title in the list of closed PRs instead of having to inspect the contents.

@sophia-guo
Copy link
Contributor Author

@smlambert agreed, I was going to exclude multiple known issues. Maybe I should convert it to Draft first.

@sophia-guo sophia-guo marked this pull request as draft April 26, 2022 17:40
@smlambert
Copy link
Contributor

smlambert commented Apr 28, 2022

some more to add (related: #3603):

java/lang/instrument/BootClassPath/BootClassPathTest.sh https://bugs.openjdk.java.net/browse/JDK-8256405 macosx-all
jdk/jfr/event/compiler/TestCompilerPhase.java #3046 windows-all

For jdk8 and jdk11:
sun/management/jmxremote/bootstrap/CustomLauncherTest.java #3238 alpine-linux?

@sophia-guo
Copy link
Contributor Author

Currently we probably don't have an easy way to exclude specific tests for alpine-linux?

@smlambert
Copy link
Contributor

re: #3611 (comment) perhaps as a temporary solution, while we figure out if there is a way to do it upstream ... create a single file called ProblemList_alpine-linux.txt that gets appended to commandline with logic in openjdk.mk ? Use that file for all versions, because so far, the issues we are seeing affect all versions, and also as it would be temporary, until a more solid approach could be done.

@smlambert
Copy link
Contributor

@sophia-guo please ignore the alpine-linux one for now ... it would be good to get this merged and backported to v0.9.1-release as vendors need the updates to prepare for marketplace (and it would help when finishing up release triage not to keep running tests that fail for known reasons).

@sophia-guo sophia-guo marked this pull request as ready for review April 29, 2022 16:17
@sophia-guo sophia-guo marked this pull request as draft April 29, 2022 16:17
@sophia-guo sophia-guo marked this pull request as ready for review April 29, 2022 16:19
@sophia-guo sophia-guo requested a review from llxia April 29, 2022 16:20
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia merged commit 706da4b into adoptium:master May 4, 2022
@sophia-guo sophia-guo self-assigned this May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
3 participants