Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use master branch instead of dev to git clone adoptOpenJDK openjdk repo #350

Merged
merged 1 commit into from
Mar 24, 2018

Conversation

sophia-guo
Copy link
Contributor

Use master branch instead of dev to git clone adoptOpenJDK openjdk repo
as master has been updated as the default branch.
Also use shallow clone to save clone time.

Signed-off-by: Sophia Guo [email protected]

@sophia-guo
Copy link
Contributor Author

When it's done, we can check #267 in #345

@sophia-guo sophia-guo self-assigned this Mar 20, 2018
Use master branch instead of dev to git clone adoptOpenJDK openjdk repo
as master has been updated as the default branch.
Also use shallow clone to save clone time.
Enable test runtime/RedefineTests/RedefineInterfaceCall.java
 
Signed-off-by: Sophia Guo <[email protected]>
@karianna
Copy link
Contributor

@sophia-guo Just to be clear - this is so you can compare the AdoptOpenJDK binary (built on dev) vs the 'pure' OpenJDK binary cloned from mercurial?

dev contains extra patches that we maintain over and above master...

@sophia-guo
Copy link
Contributor Author

@karianna we git clone from adoptopenjdk openjdk8u repo to get latest openjdk test materials, which guarantee we can always get newest test source code and newest test fixes.
Patches for build binary are not necessary for test build. Besides seems dev is not sync with mercurial, some tests are stale in dev branch.

@karianna
Copy link
Contributor

@sophia-guo We should fix dev being stale in that case as that's the branch the binaries are built from that we should be testing. I've opened adoptium/temurin-build#269

@sophia-guo
Copy link
Contributor Author

sophia-guo commented Mar 22, 2018

@karianna agreed that dev branch should be in sync with openjdk mercurial especially in openjdk10 binary build will also build test image.

For regression tests we grab tests and run tests against any supported sdk binary. Supposing master will always be a pure and in sync branch with openjdk mercurial and is the right branch to clone.

@smlambert smlambert merged commit 1916838 into adoptium:master Mar 24, 2018
@sophia-guo sophia-guo deleted the devTomaster branch August 21, 2018 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants