Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JDK18] Re-enable IllegalArgumentsTest #3322

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Conversation

babsingh
Copy link
Contributor

@babsingh babsingh commented Feb 7, 2022

The intermittent failures for IllegalArgumentsTest are fixed via
eclipse-openj9/openj9#14419.

Signed-off-by: Babneet Singh [email protected]

@babsingh
Copy link
Contributor Author

babsingh commented Feb 7, 2022

fyi @renfeiw @llxia

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@renfeiw renfeiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM, please resolve the conflict, thank you!

The intermittent failures for IllegalArgumentsTest are fixed via
eclipse-openj9/openj9#14419.

Signed-off-by: Babneet Singh <[email protected]>
@babsingh
Copy link
Contributor Author

babsingh commented Feb 7, 2022

@renfeiw Conflict removed.

@renfeiw renfeiw merged commit e60a16d into adoptium:master Feb 7, 2022
babsingh added a commit to babsingh/aqa-tests that referenced this pull request Feb 9, 2022
exeCallerAccessTest/CallerAccessTest is disabled on OSX across JDK17, 18 and 19.

Recently, a JDK19 exclude list was created using the JDK18 exclude list. The below
JDK18 changes are being applied to JDK19:

1. SpliteratorTraversingAndSplittingTest is fixed by eclipse-openj9/openj9#14430.
Related: adoptium#3331

2. IllegalArgumentsTest is fixed by eclipse-openj9/openj9#14419.
Related: adoptium#3322

Signed-off-by: Babneet Singh <[email protected]>
renfeiw pushed a commit that referenced this pull request Feb 9, 2022
exeCallerAccessTest/CallerAccessTest is disabled on OSX across JDK17, 18 and 19.

Recently, a JDK19 exclude list was created using the JDK18 exclude list. The below
JDK18 changes are being applied to JDK19:

1. SpliteratorTraversingAndSplittingTest is fixed by eclipse-openj9/openj9#14430.
Related: #3331

2. IllegalArgumentsTest is fixed by eclipse-openj9/openj9#14419.
Related: #3322

Signed-off-by: Babneet Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants