-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JDK18] Re-enable IllegalArgumentsTest #3322
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llxia
approved these changes
Feb 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
renfeiw
approved these changes
Feb 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change LGTM, please resolve the conflict, thank you!
The intermittent failures for IllegalArgumentsTest are fixed via eclipse-openj9/openj9#14419. Signed-off-by: Babneet Singh <[email protected]>
@renfeiw Conflict removed. |
babsingh
added a commit
to babsingh/aqa-tests
that referenced
this pull request
Feb 9, 2022
exeCallerAccessTest/CallerAccessTest is disabled on OSX across JDK17, 18 and 19. Recently, a JDK19 exclude list was created using the JDK18 exclude list. The below JDK18 changes are being applied to JDK19: 1. SpliteratorTraversingAndSplittingTest is fixed by eclipse-openj9/openj9#14430. Related: adoptium#3331 2. IllegalArgumentsTest is fixed by eclipse-openj9/openj9#14419. Related: adoptium#3322 Signed-off-by: Babneet Singh <[email protected]>
renfeiw
pushed a commit
that referenced
this pull request
Feb 9, 2022
exeCallerAccessTest/CallerAccessTest is disabled on OSX across JDK17, 18 and 19. Recently, a JDK19 exclude list was created using the JDK18 exclude list. The below JDK18 changes are being applied to JDK19: 1. SpliteratorTraversingAndSplittingTest is fixed by eclipse-openj9/openj9#14430. Related: #3331 2. IllegalArgumentsTest is fixed by eclipse-openj9/openj9#14419. Related: #3322 Signed-off-by: Babneet Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intermittent failures for IllegalArgumentsTest are fixed via
eclipse-openj9/openj9#14419.
Signed-off-by: Babneet Singh [email protected]