Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude jdk11 java/lang/ClassLoader/nativeLibrary/NativeLibraryTest.java #3280

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

pshipton
Copy link
Contributor

Was included via #3255 but it
fails on OpenJ9.

Issue eclipse-openj9/openj9#14351

Signed-off-by: Peter Shipton [email protected]

Copy link
Contributor

@Mesbah-Alam Mesbah-Alam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mesbah-Alam
Copy link
Contributor

I should have caught it during review of #3255!

@pshipton
Copy link
Contributor Author

I think #3255 was correct to remove the exclude after fixing adoptium/temurin-build#248, as the test was excluded under that issue. It may have then passed, but otherwise now needs a new issue as the reason for the exclude.

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia merged commit 6b7509b into adoptium:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants