Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add space after -o (output dir) in modularity native makefile #209

Merged

Conversation

Mesbah-Alam
Copy link
Contributor

Add space after -o (output dir) in modularity native makefile
Signed-off-by: [email protected]

@Mesbah-Alam Mesbah-Alam self-assigned this Dec 17, 2018
@Mesbah-Alam Mesbah-Alam requested a review from renfeiw December 17, 2018 20:53
@Mesbah-Alam
Copy link
Contributor Author

On some osx machines in openj9, the system test fails to compile (ref: eclipse-openj9/openj9#4078). This could be related to the missing space after -o that is added in this PR.

@Mesbah-Alam
Copy link
Contributor Author

Change tested in internal jenkins.

@Mesbah-Alam Mesbah-Alam merged commit 04099ac into adoptium:master Dec 17, 2018
@Mesbah-Alam Mesbah-Alam deleted the fixModularityNativeBuildMakefile branch March 20, 2019 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants