Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obligatory "doesn't work on Canary issue" #22

Closed
mitchlloyd opened this issue May 31, 2015 · 4 comments
Closed

Obligatory "doesn't work on Canary issue" #22

mitchlloyd opened this issue May 31, 2015 · 4 comments

Comments

@mitchlloyd
Copy link
Contributor

I tried upgrading an app to the latest Ember build today and I noticed that the x-select components weren't rendering anything. I ran the tests in this repo against Canary and it looks like they all fail each module has failing assertions (except for JSHint! 🎉).

I'm sure there's nothing wrong on your end. You guys are great. But those Ember core people... 😉 Maybe there is an issue that could be filed before 1.13 is out the door or maybe there is an open issue that might be affecting x-select?

@mitchlloyd
Copy link
Contributor Author

I think this is the related issue emberjs/ember.js#11301.

@Robdel12
Copy link
Collaborator

I've briefly looked at the fails on canary but haven't taken the time to troubleshoot. X-select is technically "broken" on anything 1.11+. That's due to this: emberjs/ember.js#11221

I'll take a look and see if it's on our end or not hopefully today :)

@jamesarosen
Copy link
Contributor

#33 has tests passing on Glimmer, though without support for the form attribute.

@Robdel12
Copy link
Collaborator

Robdel12 commented Jul 3, 2015

Closing this. #40 has passing tests on canary :)

@Robdel12 Robdel12 closed this as completed Jul 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants