Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(addon/components/paper-button): converts to a glimmer component. #1298

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat(addon/components/paper-button): converts to a glimmer component. #1298

wants to merge 9 commits into from

Conversation

matthewhartstonge
Copy link
Contributor

@matthewhartstonge matthewhartstonge commented Nov 7, 2024 •
edited
Loading

Removes reliance on FocusableMixin and ProxiableMixin

Builds on #1294

This was referenced Nov 7, 2024
Open
Open
@matthewhartstonge matthewhartstonge linked an issue Nov 11, 2024 that may be closed by this pull request
Convert all components using ember-composability-tools to glimmer #1292
Open
20 tasks
@matthewhartstonge matthewhartstonge force-pushed the feature/glimmer-paper-button branch 2 times, most recently from c21905e to cd4f27f Compare November 12, 2024 22:49
@matthewhartstonge matthewhartstonge changed the base branch from chore/remove-events-mixin to main November 14, 2024 07:40
@netlify Netlify
Copy link

netlify bot commented Nov 15, 2024 •
edited
Loading

✅ Deploy Preview for ember-paper ready!

Name Link
🔨 Latest commit 70b9d50
🔍 Latest deploy log https://app.netlify.com/sites/ember-paper/deploys/673a69cb1d7a720008d606e6
😎 Deploy Preview https://deploy-preview-1298--ember-paper.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 17, 2024 •
edited
Loading

Some tests with 'continue-on-error: true' have failed:

@matthewhartstonge
Copy link
Contributor Author

The dummy application had an override on classNames. This feels bad? and I've migrated the templates to use @class.

There were 3 references in total that set classNames:

  • PaperDivider: PaperList had a CSS class to constrain tomster profile image size
  • PaperSidenav(x2): was attempting to pass hide-gt-sm. (copy+pasted into /catalog)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansona mansona Awaiting requested review from mansona

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert all components using ember-composability-tools to glimmer
1 participant
@matthewhartstonge