Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

name-space scss files #247

Closed
SirZach opened this issue Dec 16, 2015 · 8 comments
Closed

name-space scss files #247

SirZach opened this issue Dec 16, 2015 · 8 comments

Comments

@SirZach
Copy link
Contributor

SirZach commented Dec 16, 2015

I had declared my own variables.scss in my styles folder and as a result, it overrode ember-paper's variables.scss file. If all the .scss files brought in by ember-paper were namespaced the likelihood of collision would reduce.

@miguelcobain
Copy link
Collaborator

#249 will fix this.
Meanwhile, I can accept a PR that renames variables.scss (or others) with paper- prefix, for example.

@SirZach
Copy link
Contributor Author

SirZach commented Jan 4, 2016

I'm not sure that it would be a good idea to only rename the one file as that will break most people's projects unless you did a bump to 0.3.x.

@miguelcobain
Copy link
Collaborator

Why would it break? People are @importing files like variables.scss?

@SirZach
Copy link
Contributor Author

SirZach commented Jan 4, 2016

True, I'm not importing variables.scss but I am importing color-palette.scss everywhere. In any case, it would still be a breaking change if someone is (perhaps to get a hold of the ember-paper's shadow styles?)

@bgohsman
Copy link

We also ran into this issue as well as conflicts with root-level variable names such as $font-family, $font-size and $primary. Prefixing names like these as well as things like $colors, $default-color, $link, $foreground, etc. may be a good idea at some point.

@DanChadwick
Copy link
Contributor

Since the styles come directly from Angular Material, I don't think we can do much about this. I see the pain tho. Please reopen if you have other ideas.

@miguelcobain
Copy link
Collaborator

@DanChadwick I'm fairly positive that this problem does not happen in wip/1.0.0 branch.

@miguelcobain
Copy link
Collaborator

well, it would happen with the scss files we have there: color-palette and default-theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants