Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: modelName undefined when serializing fragment and fragment array #407

Merged
merged 2 commits into from
Oct 7, 2021
Merged

fix: modelName undefined when serializing fragment and fragment array #407

merged 2 commits into from
Oct 7, 2021

Conversation

knownasilya
Copy link
Collaborator

Resolves #406

@knownasilya knownasilya mentioned this pull request Sep 1, 2021
Open
@knownasilya knownasilya changed the title fix: modelName undefined when serializing fragment fix: modelName undefined when serializing fragment and fragment array Sep 15, 2021
@runspired
Copy link
Contributor

I think we should accept this for now and make the correct long term fix later

@knownasilya knownasilya merged commit 4f77b2d into master Oct 7, 2021
@knownasilya knownasilya deleted the fix/model-name branch October 7, 2021 18:22
@lcmen
Copy link

lcmen commented Oct 7, 2021

Thank you @runspired for looking into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runspired runspired runspired approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Model fragments broken against Ember Data 3.28
3 participants
@knownasilya @runspired @lcmen