Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RangeError: Maximum call stack size exceeded with ED 3.14 #345

Open
IAmJulianAcosta opened this issue Nov 18, 2019 · 7 comments
Open

RangeError: Maximum call stack size exceeded with ED 3.14 #345

IAmJulianAcosta opened this issue Nov 18, 2019 · 7 comments

Comments

@IAmJulianAcosta
Copy link

Tested on brand new Ember install:

DEBUG: -------------------------------
DEBUG: Ember           : 3.14.1
DEBUG: Ember Data      : 3.14.0
DEBUG: Model Fragments : 4.0.0
DEBUG: -------------------------------
Uncaught (in promise) RangeError: Maximum call stack size exceeded
    at new CoreStore (-private.js:12583)
    at new Store (-private.js:15820)
    at Function.create (core_object.js:673)
    at FactoryManager.create (index.js:552)
    at instantiateFactory (index.js:362)
    at lookup (index.js:290)
    at processInjections (index.js:403)
    at buildInjections (index.js:419)
    at injectionsFor (index.js:434)
    at FactoryManager.create (index.js:499)

The problem is in CoreStore constructor

@gwak
Copy link

gwak commented Nov 19, 2019

Same issue here...

@jakesjews
Copy link
Contributor

jakesjews commented Nov 19, 2019

Ember-Data 3.13+ isn't supported yet. There is a WIP PR at #339 and an issue at #338

@IAmJulianAcosta
Copy link
Author

Thanks @jakesjews , I'm aware of this and downgraded to 3.12, just wanted to make sure that this was tracked

@jakesjews
Copy link
Contributor

no problem @IAmJulianAcosta! This ticket reminded me that I needed to update the readme so it was helpful.

@jelhan
Copy link

jelhan commented Nov 29, 2019

@jakesjews Would be awesome if you add an assertion that Ember Data is 3.12 or less. Maybe just a peerDependency? This error is hard to debug as the error is thrown very early and does not contain any helpful information.

@allthesignals
Copy link

allthesignals commented Jan 10, 2020

I was getting this error on what appeared to be compatible versions: #224 (comment)

    "ember-data": "^3.11.0",
    "ember-data-model-fragments": "^4.0.0",
    "ember-source": "~3.7.3",

^ I'm playing around with versions and I'm still seeing this. Here's my pull package json: https://github.com/NYCPlanning/ceqr-app/blob/548-fragments-for-transportation-planning-factors-model/package.json

RangeError: Maximum call stack size exceeded
at new DefaultStore (http://localhost:4200/assets/vendor.js:154064:3)
at Function.create (http://localhost:4200/assets/vendor.js:39430:22)
at FactoryManager.create (http://localhost:4200/assets/vendor.js:16274:39)
at instantiateFactory (http://localhost:4200/assets/vendor.js:16134:69)
at lookup (http://localhost:4200/assets/vendor.js:16093:16)
at processInjections (http://localhost:4200/assets/vendor.js:16159:34)
at buildInjections (http://localhost:4200/assets/vendor.js:16172:13)
at injectionsFor (http://localhost:4200/assets/vendor.js:16184:16)
at FactoryManager.create (http://localhost:4200/assets/vendor.js:16232:49)
at instantiateFactory (http://localhost:4200/assets/vendor.js:16134:69)

RangeError: Maximum call stack size exceeded
at Arguments.values ()
at Registry.resolve (http://localhost:4200/assets/vendor.js:16445:41)
at has (http://localhost:4200/assets/vendor.js:16826:25)
at Registry.has (http://localhost:4200/assets/vendor.js:16527:20)
at Registry.proto.validateInjections (http://localhost:4200/assets/vendor.js:16776:35)
at processInjections (http://localhost:4200/assets/vendor.js:16148:36)
at buildInjections (http://localhost:4200/assets/vendor.js:16172:13)
at injectionsFor (http://localhost:4200/assets/vendor.js:16184:16)
at FactoryManager.create (http://localhost:4200/assets/vendor.js:16232:49)
at instantiateFactory (http://localhost:4200/assets/vendor.js:16134:69)

This is weird, I'm completely stuck. Switching around versions doesn't seem to do anything. I still see this error everywhere. When I remove the addon, it goes away. It's bizarre that I was able to develop a feature with it with no problem. When I upgraded yarn, however, a large number of things were changed in the generated yarn.lock. I don't know what caused them or why, but it could be that some version drift somewhere changed some nuance and now simply having the addon in the app breaks it.

@BryanCrotaz
Copy link

This is fixed in ED 3.17.1 and 3.18. It was a bug in the ED store.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants