You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Need to fix all the errors and warnings when compiling on the MSVC platform.
Some sample errors and warnings:
./source\io\Deserializer.cpp(235): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data
./source\io\Deserializer.cpp(254): error C2908: explicit specialization; 'T Deserializer<T>::nextValue(void)' has already been instantiated
The text was updated successfully, but these errors were encountered:
The issue was mostly the following things are to be considered when compiling with MSVC:
We need to use _mkgmtime in place of timegm
We need to import <windows.h> for min and max functions to work
When doing put_time, %z does not work as expected, hence best avoid it
Fix DLL importing logic for Windows Python 3.8+
Additional notes for 4: For Python versions 3.8+, DLL importing mechanism changed significantly (Refer: https://docs.python.org/3/whatsnew/3.8.html#bpo-36085-whatsnew). Hence we need additional logic within the codebase to call os.add_dll_directory with appropriate path from which the DLLs can be loaded, which in our case is the geos_c.dll. Accordingly, I had to find a way to include python code to run along with the existing C++ extension module which is built with pybind11. So some refactoring has been done for that in 1add9c1.
Need to fix all the errors and warnings when compiling on the MSVC platform.
Some sample errors and warnings:
The text was updated successfully, but these errors were encountered: