Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LinkedIn Provider to Use OpenId Connect #154

Open
LoicOuth opened this issue Aug 14, 2024 · 4 comments
Open

Update LinkedIn Provider to Use OpenId Connect #154

LoicOuth opened this issue Aug 14, 2024 · 4 comments

Comments

@LoicOuth
Copy link

LoicOuth commented Aug 14, 2024

Package version

5.0.2

Describe the bug

The current LinkedIn provider utilizes the Sign In With LinkedIn method, which has been deprecated as of August 2023. LinkedIn has introduced a new method, with OpenId Connect, which needs to be adopted to ensure the package remains functional and up-to-date.

  • The transition from last method to OpenId Connect involves several changes, including updates to the scopes and some of the APIs used.
  • LinkedIn's documentation for the new method can be found here.

I would like to propose a PR to update the LinkedIn provider to use the new method. This update will include changes to the scopes and adjustments to the related API calls to ensure compatibility with LinkedIn's latest requirements.

Please let me know if you would like me to proceed with the PR or if there are any other considerations to take into account.

Thank you!

Reproduction repo

No response

@LoicOuth LoicOuth changed the title Update LinkedIn Provider to Use SignInWithLinkedInUsingOpenIdConnect Update LinkedIn Provider to Use OpenId Connect Aug 14, 2024
@shiny
Copy link

shiny commented Sep 29, 2024

I'm also looking forward to OpenID Connect support, not for LinkedIn, but for Google One Tap.
It has a good user experience.
https://developers.google.com/identity/gsi/web/guides/features

@LoicOuth
Copy link
Author

Hello, I made a package to connect using LinkedIn openid connect, if you want to create own
https://www.npmjs.com/package/adonis-ally-linkedin-openid-connect

@roslove44
Copy link

Thanks for the package. I wasted almost a week on this problem, thinking that the error was mine.

@LoicOuth
Copy link
Author

LoicOuth commented Nov 4, 2024

Thanks for the package. I wasted almost a week on this problem, thinking that the error was mine.

If you have an error on my package you can open an issue here with details and i will help you : https://github.com/LoicOuth/adonis-ally-linkedin-openid-connect/issues 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants