Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #37 and #36, for all of the "single samplers" adds methods
getindex
,length
,keys
, andkeytype
(see src/sample/interface.jl), and added tests.Additionally:
MutableBinaryHeap
to aMutableBinaryMinHeap
in the combined next reaction samplerBase.getindex
should return for theDirectCall
sampler (see src/sample/direct.jl), I thought the leaf nodes of the prefix tree would be the distribution rate parameter but it does not seem to be the case. Can you help me take a look at that? That's why the newly added test in test_direct.jl is commented out. I also addedBase.getindex
methods to some of the trees in src/prefixsearch. This also raises the general question of what it should return as in some cases we store distributions and in other cases we store sampled times.