Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please remove dependencies on **rgdal**, **rgeos**, and/or **maptools** #545

Closed
rsbivand opened this issue Dec 14, 2022 · 7 comments
Closed
Assignees
Milestone

Comments

@rsbivand
Copy link

This package depends on (depends, imports or suggests) raster and one or more of the retiring packages rgdal, rgeos or maptools (https://r-spatial.org/r/2022/04/12/evolution.html). Since raster 3.6.3, all use of external FOSS library functionality has been transferred to terra, making the retiring packages very likely redundant. It would help greatly if you could remove dependencies on the retiring packages as soon as possible.

@adokter
Copy link
Owner

adokter commented Dec 19, 2022

Thanks @rsbivand for the heads up, updating all our spatial libraries is at the top of our to-do list for 2023

@rsbivand
Copy link
Author

This package has strong dependence on at least one of rgdal, rgeos or maptools, but does not seem to use any functionality in code. The usage may have been in raster, which now uses terra instead, or may be in examples or vignettes. Please move all use of rgdal, rgeos or maptools to Suggests: and protect any use against these packages not being present. The packages will be archived in October 2023. See https://r-spatial.org/r/2022/12/14/evolution2.html and https://rsbivand.github.io/csds_jan23/bivand_csds_ssg_230117.pdf and perhaps view https://www.youtube.com/watch?v=TlpjIqTPMCA&list=PLzREt6r1NenmWEidssmLm-VO_YmAh4pq9&index=1.

@rsbivand
Copy link
Author

See also https://r-spatial.org/r/2023/04/10/evolution3.html, please fix best by June, latest October 2023.

@adokter
Copy link
Owner

adokter commented Apr 25, 2023

@rsbivand thanks, we will move this up in priority. Do you have plans for maptools::crepuscule() to be migrated to a different package? If not, would it be ok if we integrate that piece of code into bioRad under the GPL license used by maptools? Or would you recommend a different option?

@rsbivand
Copy link
Author

That would of course be fine. I took the functions out as https://github.com/rsbivand/sunMaptools in connection with contacts with other package maintainers:

packages birdscanR BirdScanCommunity/birdscanR#34 EMbC FLightR eldarrak/FLightR#24 incR PabloCapilla/incR#3 PWFSLSmoke MazamaScience/PWFSLSmoke#124 shadow michaeldorman/shadow#7 StreamMetabolism ssefick/StreamMetabolism#2.

@iskandari
Copy link
Collaborator

Add suntools package as a dependency once it is published on CRAN

@rsbivand
Copy link
Author

rsbivand commented Jun 9, 2023

CRAN bioRad_0.6.2.tar.gz fails CMD check with _R_CHECK_SUGGESTS_ONLY_=true and forthcoming sp 2.0-0; adding sf to Suggests: remedies. I couldn't test properly with your Github HEAD which has sf because I don't have vol2birdR. sp 2.0-0 is coming during June.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants