XDM -1723 updating DirectMail Feedback #1724
Conversation
|
@chetanmeh @sawhneyh @mjasrotia : Please take a look |
| "type": "string", | ||
| "description": "Direct Mail FileName" | ||
| }, | ||
| "https://ns.adobe.com/experience/customerJourneyManagement/directMailChannelContext/directMaildestinationId": { |
There was a problem hiding this comment.
directMaildestinationId ==> directMaildestinationID
There was a problem hiding this comment.
Thanks @mjasrotia
Updated
There was a problem hiding this comment.
@nikshar : It seems fields under directMailChannelContext are not event(user) specific but Action specific. I don't think we should be ingesting action level fields in user specific events.
We should review whether we can use entity dataset for ingesting these fields.
cc: @chetanmeh
There was a problem hiding this comment.
Seems like you folks are discussing this internally. Please post here once this is good to be reviewed. Thanks !
Moved this to AJO Entity Mixin as per reviews
trivial change
|
@anshchauhan : I've updated the entity schema for Direct mail Channel |
| "description": "Direct Mail Routing Destination, non-personalized" | ||
| }, | ||
| "https://ns.adobe.com/experience/customerJourneyManagement/entities/directMailFileName": { | ||
| "title": "Direct Mail FileName", |
There was a problem hiding this comment.
@nikshar: Is this property a function of batch recurrence or a property of messagePublication?
As per my understanding we add entry in entityDataset at messagePublication, so if this property is at batch recurrence level we won't be able to override this value or preserve value at batch recurrence.
cc: @chetanmeh
There was a problem hiding this comment.
@sawhneyh: for DM we'll ingest this at export time
at message publication time we don't ingest this value.
this is a batch level property
There was a problem hiding this comment.
In that case, are we changing the key for this dataset? Currently key for this dataset is a function of MessagePublicationId and VariantId.
|
closing because it has been open from very long. Please re-open if required |
Please link to the issue #…
XDM -1723 updating DirectMail Feedback