Allow concurrent broker restarts from same AZ (broker rack) #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrlaltluc
force-pushed
the
luciani/parallel-restart
branch
from
f312d0f
to
420ba3a
Compare
ctrlaltluc
changed the title
amuraru
reviewed
Jun 6, 2023
amuraru
reviewed
Jun 6, 2023
amuraru
reviewed
Jun 6, 2023
amuraru
approved these changes
Jun 6, 2023
ilievladiulian
approved these changes
Jun 6, 2023
ilievladiulian
approved these changes
Jun 6, 2023
ctrlaltluc
added a commit
that referenced
this pull request
Jun 8, 2023
* Allow parallel broker restarts from same AZ (broker rack) * Change parameter description to be more accurate * Address CR comments
ctrlaltluc
added a commit
that referenced
this pull request
Jun 8, 2023
* Allow parallel broker restarts from same AZ (broker rack) * Change parameter description to be more accurate * Address CR comments
amuraru
added a commit
that referenced
this pull request
Jun 10, 2023
amuraru
added a commit
that referenced
this pull request
Jun 10, 2023
amuraru
added a commit
that referenced
this pull request
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cluster restarts are time consuming for big clusters.
Given that we are using Kafka
broker.rackconfig to spread replicas across 3 AZs, we can speed up the cluster restart by allowing concurrent broker restarts within the same AZ. Allowing only same AZ concurrent restarts makes sure that we always have at most 1/3rd of the replicas of any topic-partition offline, not more.Key changes:
RollingUpgradeConfig.ConcurrentBrokerRestartsAllowedwhich is by default 1RollingUpgradeConfig.ConcurrentBrokerRestartsAllowedandRollingUpgradeConfig.FailureThresholdRollingUpgradeConfig.FailureThresholdby allowing (same as before) multiple failures even if not in the same AZbroker.rackis not properly configured for all brokers, consider each broker as being in a separate AZ, meaning we err on the side of caution and restart at most 1 broker at onceNote: in order to enable multiple concurrent restarts, we must set both
RollingUpgradeConfig.ConcurrentBrokerRestartsAllowedandRollingUpgradeConfig.FailureThresholdto a value above 1