Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reject dangerous url characters (--open) #2258

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

tripodsan
Copy link
Contributor

fixes #2257

@github-actions
Copy link

This PR will trigger a patch release when merged.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #2258 (bb9f3f1) into main (c78ec5a) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2258      +/-   ##
==========================================
- Coverage   93.44%   93.39%   -0.06%     
==========================================
  Files          26       26              
  Lines        3571     3574       +3     
  Branches        1        1              
==========================================
+ Hits         3337     3338       +1     
- Misses        234      236       +2     
Files Coverage Δ
src/abstract-server.cmd.js 80.13% <100.00%> (+0.41%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tripodsan tripodsan merged commit 25df8e8 into main Oct 18, 2023
7 of 8 checks passed
@tripodsan tripodsan deleted the reject-dangerous-open-urls branch October 18, 2023 11:14
tripodsan pushed a commit that referenced this pull request Oct 18, 2023
## [15.0.2](v15.0.1...v15.0.2) (2023-10-18)

### Bug Fixes

* reject dangerous url characters (--open) ([#2258](#2258)) ([25df8e8](25df8e8)), closes [#2257](#2257)
@tripodsan
Copy link
Contributor Author

🎉 This PR is included in version 15.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most important thing is I don't know anything about this if they is a way you can be of help fixing issues you know it's not right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: validate urls before opening them [AEM-04]
2 participants