Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

CodeHintManager should use the new LanguageManager #3085

Closed
tomsdev opened this issue Mar 9, 2013 · 4 comments
Closed

CodeHintManager should use the new LanguageManager #3085

tomsdev opened this issue Mar 9, 2013 · 4 comments

Comments

@tomsdev
Copy link

tomsdev commented Mar 9, 2013

It would be great if CodeHintManager.registerHintProvider could take a language id provided by the new LanguageManager instead of modes in parameter. I think it's better because a language id won't change but modes can change or be added for a language.

@njx
Copy link
Contributor

njx commented Mar 11, 2013

Hi @tomsdev -- thanks for the suggestion. We're considering a number of API changes like this as part of our ongoing research into language extensibility on this card: https://trello.com/c/08EM5OiP -- a number of the API changes we haven't made yet are listed on this wiki page: https://github.com/adobe/brackets/wiki/Language-Support. We haven't yet prioritized the work to actually make those changes yet though--is this a blocker for your TypeScript support, or is it something that could wait until later?

@tomsdev
Copy link
Author

tomsdev commented Mar 11, 2013

Hi @njx. It's not a blocker for the moment because the TypeScript language is not defined in Brackets but in my extension. So, I know the "modes" that it uses. But when it will be defined in Brackets it will be difficult to know the modes I have to register for in CodeHintManager. It's really simpler to just give the language id.

@WebsiteDeveloper
Copy link
Contributor

@tomsdev this should be done right now

@tomsdev
Copy link
Author

tomsdev commented Apr 6, 2013

Thanks, well done @WebsiteDeveloper

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants