Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Mashing F5 crashes Brackets #10779

Open
petetnt opened this issue Mar 22, 2015 · 13 comments
Open

Mashing F5 crashes Brackets #10779

petetnt opened this issue Mar 22, 2015 · 13 comments

Comments

@petetnt
Copy link
Collaborator

petetnt commented Mar 22, 2015

Found this small issue that most won't run into when testing out for #10769 but anyway:

(Windows 8.1., Brackets 1.2.)

  1. Open Brackets
  2. Repeatedly reload the project with F5
  3. Soon-ish Brackets hangs and can only be terminated via Task Manager:

image

@prksingh
Copy link
Contributor

Am able to reproduce on Windows 7 as well. Thanks for reporting. Adding 'move to backlog' so we can assign some priority to this. Looks like a very rare scenario so may not be an urgent fix.

@ryanstewart
Copy link
Contributor

Marking low priority.

@petetnt
Copy link
Collaborator Author

petetnt commented Apr 15, 2015

Just noticed when trying out #10906 that holding down F5 will crash Brackets within seconds

@sagiegurari
Copy link

Why is this one low priority? When you install an extension it results in reload and can freeze brackets.
The only way out is to kill the brackets process.
After 6 months with this issue, I'm not sure that anyone is looking at this.

@abose
Copy link
Contributor

abose commented Oct 19, 2015

This has been fixed in 1.5. Please update to latest version 👍

@abose abose closed this as completed Oct 19, 2015
@abose
Copy link
Contributor

abose commented Oct 19, 2015

Feel free to reopen this issue if you find this in the latest version.

@sagiegurari
Copy link

I saw the setTimeout workaround, but I still reproduced it with 1.5
Are you 100% sure this doesn't happen to others with 1.5?

@petetnt
Copy link
Collaborator Author

petetnt commented Oct 19, 2015

I am almost sure (I haven't installed the newest build yet that ships with different shell I have on now...) that this particular bug is similar to, but not fixed by #11505. Smashing F5 still crashes Brackets for good: easiest way to reproduce this is by holding F5 while Brackets is active.

@petetnt
Copy link
Collaborator Author

petetnt commented Oct 19, 2015

Confirmed against latest master with the newest shell: The #11505 helps but does not completely fix this issue.

@abose
Copy link
Contributor

abose commented Oct 19, 2015

Does this happen when you press f5 and then while brackets is reloading, press f5 again- that is causing a crash in my machine. But simply pressing f5 and waiting for the reload to complete does not cause the crash.

@abose
Copy link
Contributor

abose commented Oct 19, 2015

Maybe a fix would be to hold off reloading till brackets app ready is done?

@sagiegurari
Copy link

Yes exactly

@petetnt
Copy link
Collaborator Author

petetnt commented Oct 19, 2015

@abose I think yes. Currently holding down F5 constantly reloads the page (it's Chromium behaviour), so debouncing the reload event could help too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants