Audit log support #806
Merged
Audit log support #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added unit tests for 100% coverage
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #806 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 56 57 +1
Lines 3243 3323 +80
Branches 617 641 +24
=========================================
+ Hits 3243 3323 +80 ☔ View full report in Codecov by Sentry. |
shazron
approved these changes
Jun 11, 2024
purplecabbage
requested changes
Aug 26, 2024
added 2 commits
September 25, 2024 17:38
added 2 commits
September 25, 2024 18:18
amulyakashyap09
requested review from
amulyakashyap09,
arjuncooliitr,
moritzraho and
MichaelGoberling
MichaelGoberling
approved these changes
Oct 1, 2024
| * @param {string} env valid env stage|prod | ||
| */ | ||
| async function sendAuditLogs (accessToken, logEvent, env = 'prod') { | ||
| const url = AUDIT_SERVICE_ENPOINTS[env] |
There was a problem hiding this comment.
This could be null, what do you do if your not passed 'prod' or 'stage'
You should just default to prod ...
const url = env === 'stage' ? AUDIT_SERVICE_ENPOINTS.stage : AUDIT_SERVICE_ENPOINTS.prod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE (util we have service deployment in place)
Support to send audit log events on app deploy.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: