Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency on node-pre-gyp to @mapbox/node-pre-gyp #3

Closed
Ghazgkull opened this issue Sep 8, 2021 · 6 comments
Closed

Update dependency on node-pre-gyp to @mapbox/node-pre-gyp #3

Ghazgkull opened this issue Sep 8, 2021 · 6 comments

Comments

@Ghazgkull
Copy link

@mapbox/node-pre-gyp replaces the deprecated node-pre-gyp. The deprecated version is currently flagged because of high severity vulnerabilities, causing npm audit to fail.

@adnanrahic

@Ghazgkull
Copy link
Author

@adnanrahic For some context, the Promster NPM module for exporting Prometheus metrics recently moved to your fork of node-gcstats because of the dependency updates you made to eliminate vulnerabilities reported by npm audit.

Would you mind clarifying whether you're planning to maintain this fork? If so, are you able to update the node-pre-gyp dependency? Are you open to PRs?

@rohitkumarcs
Copy link

@Ghazgkull @adnanrahic
Are these vulnerability fixes part of NPM yet? We would be interested in using it

@Ghazgkull
Copy link
Author

@adnanrahic Please review the PR I submitted here: #4

@rohitkumarcs
Copy link

@Ghazgkull
Are you planning to publish your changes in NPM as a new library in case is not taken care here? We find it useful for us too instead of writing a new one for same purpose.

@adnanrahic
Copy link
Owner

Hey everyone!

Sorry for not responding sooner. 😞
I was maintaining this fork while working at https://github.com/sematext.

I've moved to work somewhere else recently, so I'm not sure if I have publish permissions to the npm package https://www.npmjs.com/package/@sematext/gc-stats.

Let me merge #4 first so there is an option to use this fork by installing it directly from GitHub.

Thanks a lot for taking the time to create the PR @Ghazgkull! Really great work!

@adnanrahic
Copy link
Owner

Seems I still have publish access! 🚀 🎊
Latest version is now: https://www.npmjs.com/package/@sematext/gc-stats/v/1.5.4
Thanks for looking into this and adding a fix. 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants