Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use arrays as Parameters in queries #194

Open
1 task done
BirgitBoss opened this issue Nov 3, 2023 · 1 comment
Open
1 task done

Do not use arrays as Parameters in queries #194

BirgitBoss opened this issue Nov 3, 2023 · 1 comment
Milestone
3.x

Comments

@BirgitBoss
Copy link
Collaborator

BirgitBoss commented Nov 3, 2023 •
edited
Loading

What?

The querying of complex parameter objects like array of specificAssetIds in https://app.swaggerhub.com/apis/Plattform_i40/DiscoveryServiceSpecification/V3.0.1_SSP-001#/Asset%20Administration%20Shell%20Basic%20Discovery%20API/GetAllAssetAdministrationShellIdsByAssetLink leads to a lot of problems with respect to encoding etc.

How?

Instead of using an array as parameter put the information into the body of the query

This issue relates to finding XX#??.
Incorrect handling of assetids in /lookup/shells endpoint · Issue #201 · eclipse-tractusx/sldt-digital-twin-registry (github.com)
#162
#193
#191
#19

  • I have signed the required Developer Certificate of Origin (DCO) already.
@BirgitBoss
Copy link
Collaborator Author

will be solved with #19 for GetAllAssetAdministrationSellIdsByAssetLinks
The decision should be documented in design decisions.
If there is not other operation with array as parameter this issue can be closed

@BirgitBoss BirgitBoss added this to the 3.x milestone Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.x
Development

No branches or pull requests
1 participant
@BirgitBoss