-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
missing SAC headers while reading SPECFEM3D_cartesian data #132
Labels
Comments
bch0w
added a commit
that referenced
this issue
Feb 29, 2024
adding warning messages to sac header append when evdp or mag not present
bch0w
added a commit
that referenced
this issue
Feb 29, 2024
* extending read_sem_cartesian test to check for evdp related to #132 adding warning messages to sac header append when evdp or mag not present * extended cartesian sac headers to match all normal sac header values except for cmpinc and cmpaz added better warning message for missing sac header values in normal sac header reading extended tests to cover new functionalities
Hi @aakash10gupta, this should be fixed in #138, can you test and let me know if you are able to access the new SAC headers for Cartesian synthetics? |
bch0w
added a commit
that referenced
this issue
Apr 19, 2024
* added read function for asdfdatasets and allow RecSec to plot windows on top of record section (#136) * added test to check zero division error, (#137) added logger warning about zero amplitude scaling feature: user can now set kwargs for obs_color and syn_color * Improve SAC header append functions (#138) * extending read_sem_cartesian test to check for evdp related to #132 adding warning messages to sac header append when evdp or mag not present * extended cartesian sac headers to match all normal sac header values except for cmpinc and cmpaz added better warning message for missing sac header values in normal sac header reading extended tests to cover new functionalities * Improve RecSec preprocessing architecture (#139) * reorganizing docstring, restructuring preprocess flag default value for overwrite is now set True so User does not have to unset changed default preprocess flag to True, removed 'both' option * fixed up check function to reflect new preprocess flag * restructuring preprocessing function to put each individual feature behind a boolean flag so that they can be turned on/off at will also expose some key arguments as keyword arguments so the User has more control * all preprocessing now behind tunable knobs * moved kwargs to args of process_st reorganized init parameter input to organize a bit better added new parameters to main docstring * allow preprocess=True to be more flexible and just take st and st_syn if available, removed hard check on preprocess=True requireing st_syn to be more intutive by users bugfix move fill value to after assignment of trace in loop * moved parameters back to internal kwargs to match recsec structure and allow passing them in through command line * bump version 0.6.0 and bump copyright year in docs * update changelog * slim down changelog to include only most recent
Hi @bch0w, yes I'm able to access the new SAC headers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It looks like pysep (read_sem) is not reading in available information into SAC headers while reading in data from SPECFEM3D_cartesian. This probably happens when the source/stations are defined in the cartesian coordinate system instead of the geographical coordinate system. The missing headers include 'b' and 'evdp' among other possible missing headers.
The text was updated successfully, but these errors were encountered: