Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

picture comparison depands on the matplotlib version #11

Open
wjlei1990 opened this issue Mar 25, 2016 · 2 comments
Open

picture comparison depands on the matplotlib version #11

wjlei1990 opened this issue Mar 25, 2016 · 2 comments

Comments

@wjlei1990
Copy link

Hi Lion,

I replace the comparison picture using matplotlib 1.4.3 and then the tests about picture comparison passed without any issue. However, when I installed pyflex on my local computer, it failes with matplotlib 1.5.1.

Here is the diff result:
picked_windows-failed-diff

Which I think just some texts position difference.

@krischer
Copy link
Collaborator

Yea that happens. There are three possible solutions:

  • Up to tolerance for matplotlib 1.5.1
  • Create two sets of test images
  • Create the baseline images for matplotlib 1.5.1 and up the tolerances for all lower matplotlib version

I vote for the last one. I can take care of it if you want to.

@wjlei1990
Copy link
Author

OK. I will leave it to you...

Do you think we can merge our two branches recently? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants