Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo gets distorted #59

Closed
plaihonen opened this issue Feb 28, 2019 · 4 comments
Closed

Logo gets distorted #59

plaihonen opened this issue Feb 28, 2019 · 4 comments
Labels
bug Something isn't working
Milestone

Comments

@plaihonen
Copy link

Logo gets distorted due to the both width and height being defined in the style.
<img src="%s" style="height:18vh!important;width:95%;"/>

If the width is omitted, then the logo aspect ratio remains correct.
<img src="%s" style="height:18vh!important;"/>

This would work fine when logo is provided as a square image. (ex. 512x512 pixels.)

@adiralashiva8 adiralashiva8 added the bug Something isn't working label Feb 28, 2019
@fspegni
Copy link
Contributor

fspegni commented Apr 18, 2019

On the other side, in different scenarios, it may be that a short but wide image is "cropped" with your suggestion. Perhaps setting the max-height and max-width should solve the original problem of not showing a distorted image, no matter its height/width ratio, e.g.

<img src="%s" style="max-height:18vh;max-width:95%%;"/>

@adiralashiva8
Copy link
Owner

Fixed as part of #65 pull request

@adiralashiva8
Copy link
Owner

Seems this issue not fixed, Modifying sidebar will fix this issue

@adiralashiva8 adiralashiva8 reopened this May 11, 2019
@adiralashiva8 adiralashiva8 added this to the v-3-1-2 milestone May 11, 2019
@adiralashiva8
Copy link
Owner

Modified sidebar which fixes image distorting in this commit 3cb7a5f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants