Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev reloader should only reload after error once #8

Closed
paulsmith opened this issue Aug 11, 2022 · 2 comments
Closed

Dev reloader should only reload after error once #8

paulsmith opened this issue Aug 11, 2022 · 2 comments

Comments

@paulsmith
Copy link
Contributor

Related to #4, if the build of the generated Pushup app fails for any reason, the dev reloader enters an infinite loop, until the user either Ctrl-C's out of it or fixes the build.

The reloader should detect the error condition and wait until the file change notifier reports a change.
@paulsmith
Copy link
Contributor Author

baa912f fixed the problem of the infinite loop (see also #4) but the reloader exits, instead of waiting for a new file change event and trying to rebuild.

@paulsmith
Copy link
Contributor Author

Closing in favor of new issue #79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paulsmith