Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: shorthand time format does not work as expected #501

Closed
1 task done
weberval opened this issue Oct 25, 2024 · 4 comments · Fixed by #544
Closed
1 task done

[BUG]: shorthand time format does not work as expected #501

weberval opened this issue Oct 25, 2024 · 4 comments · Fixed by #544
Labels
bug Something isn't working enhancement This issue or pull request discusses non feature changes frontend This issue or pull request is frontend related

Comments

@weberval
Copy link

Description

The shorthand military time feature when entering durations is nice, but does not work as expected.

Steps to Reproduce

  1. got to timesheet
  2. fill the mandatory fields for a task
  3. enter 15 as Task duration
  4. receive an error

Expected Behavior

I would expect the following algorithm for the shorthand feature:

  1. All numerical values are padded to four digits with leading zeros
  2. A colon is inserted after the 2nd digit.

I understand that this is probably because 1 expands to 1:00. However, as 100 is already 1:00, I would expect 15 to be 0:15.

In environments, where only 0, 15, 30 and 45 are allowed for the minute part of the duration, additional shorthands for 1 → 1:00, 2 → 2:00, etc. could be added for all single digit inputs.

Attachments

No response

Additional Context

No response

Version

v4.6.0

Required

  • I have checked past issues to see if this bug has already been reported.
@weberval weberval added the bug Something isn't working label Oct 25, 2024
@c0rydoras c0rydoras added the unable-to-reproduce Unable to reproduce issue label Oct 25, 2024
@c0rydoras
Copy link
Collaborator

15 as task duration doesn't throw an error for me.

additionally the current implementation does what was specified in #168 which states:

e.g. if I type in "730" - it would be auto-formatted into "07:30", or "1615" -> "16:15", "15" would become "15:00".

Therefore 15 -> 15:00 is not a bug.

@weberval
Copy link
Author

Okay, sorry. In this case, s/15/30/ "Steps to Reproduce".

Still a bug.

@c0rydoras c0rydoras added frontend This issue or pull request is frontend related and removed unable-to-reproduce Unable to reproduce issue labels Oct 25, 2024
@c0rydoras c0rydoras added this to timed Oct 25, 2024
@weberval
Copy link
Author

weberval commented Oct 25, 2024

Okay, I get it. Do I have to make an additional request to correct the faulty specification for 15 expanding to 1500?

@c0rydoras c0rydoras added the enhancement This issue or pull request discusses non feature changes label Oct 25, 2024
@c0rydoras
Copy link
Collaborator

Should be fine like this

@c0rydoras c0rydoras changed the title [BUG]: Shorthand time format does not work as expected [BUG]: shorthand time format does not work as expected Dec 5, 2024
@github-project-automation github-project-automation bot moved this to ✅ Done in timed Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement This issue or pull request discusses non feature changes frontend This issue or pull request is frontend related
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants