From 685cf79b637597aeb4b3984e8236ab2f9073bb8a Mon Sep 17 00:00:00 2001 From: Andrew Cooke <45248509+cookeac@users.noreply.github.com> Date: Thu, 4 Jun 2020 21:54:03 +1200 Subject: [PATCH 1/3] Update readme with instruction to link PRs to issues --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 453be7f..025cf13 100644 --- a/README.md +++ b/README.md @@ -29,4 +29,5 @@ Version 1.0 of this standard was based on previous work of: The Animal Data Exchange Working Group welcome contributions * Read and make suggestions using the [Issues List](https://github.com/adewg/ICAR/issues) * Propose changes by logging an issue, then creating your own fork and proposing a Pull Request that will be reviewed by the maintainers. +* Ensure that your pull request references the issues that it addresses (see https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue). This is part of the review criteria for maintainers, as it makes our release change logs informative. From 010b860b43a8f37a372247771aca2e951a618e65 Mon Sep 17 00:00:00 2001 From: cookeac Date: Fri, 5 Jun 2020 20:19:59 +1200 Subject: [PATCH 2/3] Explain icarValidSampleFillingIndicator #116 --- enums/icarValidSampleFillingIndicatorType.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/enums/icarValidSampleFillingIndicatorType.json b/enums/icarValidSampleFillingIndicatorType.json index 5be2066..9ee6872 100644 --- a/enums/icarValidSampleFillingIndicatorType.json +++ b/enums/icarValidSampleFillingIndicatorType.json @@ -1,5 +1,5 @@ { - "description": "Indicator of valid sample filling according to ICAR_ValidSampleFillingIndicatorCode list", + "description": "Validity of sample based on milk volume: 0=success (>80% expected milk), 1=incomplete (< 20% expected milk), 2=completed (with between 20-80% expected milk).", "type": "string", From 5e3a07880ddd40af8fc750677f47ed84d1ce33a5 Mon Sep 17 00:00:00 2001 From: cookeac Date: Fri, 5 Jun 2020 20:39:46 +1200 Subject: [PATCH 3/3] Fix icarQuarterId enum --- types/icarQuarterMilkingType.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/types/icarQuarterMilkingType.json b/types/icarQuarterMilkingType.json index 1d50e19..cd9c3ff 100644 --- a/types/icarQuarterMilkingType.json +++ b/types/icarQuarterMilkingType.json @@ -10,8 +10,8 @@ "enum": [ "LF", "RF", - "LB", - "RB" + "LR", + "RR" ] }, "quarterMilkingDuration": {