Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve device references in events #411

Closed
cookeac opened this issue Sep 12, 2023 · 1 comment · Fixed by #428
Closed

Improve device references in events #411

cookeac opened this issue Sep 12, 2023 · 1 comment · Fixed by #428

Comments

@cookeac
Copy link
Collaborator

cookeac commented Sep 12, 2023

Several events have a device property which is intended to identify the device that is the source of the event.
However, device is an icarDeviceReferenceType, which derived from an icarResourceReferenceType is intended to provide the ID and optionally a URL to get details of the resource (in this case the device). It extends this type, adding model (a string) and serial (a serial number string).

There is also icarDeviceResource which defines a more useful set of device properties:

  • name,
  • description,
  • id
  • manufacturer
  • softwareVersion
  • hardwareVersion

It would be good if this information were available with each event, rather than having to be fetched separately through a dereferenced call to get a device with that ID (particularly if the API to get devices was not implemented!).

A potential solution would be to add the properties of icarDeviceResource to the device property in events, perhaps through an allOf. The only required property is id which is required in a reference type anyway.

@cookeac
Copy link
Collaborator Author

cookeac commented Nov 2, 2023

During discussions at the technical meetings on 5 October 2023 and 19 October 2023, we decided that only the manufacturer needed to be added to the icarDeviceReferenceType. The other more detail fields can stay in icarDeviceResource and be retrieved when necessary (if that API is implemented).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant