Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide predictions for expected milk yield #285

Closed
dirbSEGES opened this issue Mar 9, 2022 · 6 comments · Fixed by #381
Closed

Provide predictions for expected milk yield #285

dirbSEGES opened this issue Mar 9, 2022 · 6 comments · Fixed by #381
Assignees
Labels
agenda-next-meeting next-minor-release The issue is not scheduled for the current release, but planned for a release soon after that.

Comments

@dirbSEGES
Copy link

Hi,

Could TestDayResultEventResource have a new property: "milkWeightExpected" or "milkWeightGoal" ?

BR

@cookeac
Copy link
Collaborator

cookeac commented Mar 24, 2022

We agree we should add milkWeight24HoursPredicted.
It would also be useful to consider how predictions are interchanged more generally.

@cookeac
Copy link
Collaborator

cookeac commented May 19, 2022

Erwin will investigate this.

@erwinspeybroeck
Copy link
Collaborator

erwinspeybroeck commented Aug 19, 2022

  1. it is possible to add predicted fields to the test day result API - on our database they are called:
  • milkWeightExpected
  • fatWeightExpected
  • ProteinWeightExpected
    Andrews proposal is maybe better since it makes clear that it 's a 24 hours expected weight
  • milkWeight24HoursPredicted
  • fatWeight24HoursPredicted
  • proteinWeight24HoursPredicted
  1. we deliver now to feeding companies also milk-predictions
    This contains in fact information (milk, fat and protein) about the expected lactation curve:
  • expected average 24 hour production for the rest of the lactation (end based on expected calving date)
  • if the peak of the lactation still has to occur : the exact days in milk the peak will be reached and the predicted 24 h production on that peak
  • the predicted 24h production on the next (in the future) milk recording (if no info about when - 3 weeks is taken as interval

Do we need to define an ICAR standard API for this? I will need it to phase out some old software. I might define it for now in the way we want to provide this information to our customers. Has naybody else such kind of information they share at this moment?

@cookeac
Copy link
Collaborator

cookeac commented Aug 25, 2022

We discussed at our meeting on 2022-08-25 and agreed that it would make sense to have a message such as that described in option 2 - a more generalised lactation prediction for individual animals. We wondered if this might avoid having to have prediction fields in the test day resource. However, if the lactation prediction was always future-focused, you could then lose the previous prediction for the test day, and not be able to compare it.
@erwinspeybroeck will start to model this up (code, diagram, or documentation - any is fine) and we will review and discuss at a future meeting.

@cookeac cookeac added the next-minor-release The issue is not scheduled for the current release, but planned for a release soon after that. label Oct 6, 2022
@erwinspeybroeck
Copy link
Collaborator

I did the following:

  • added predicted fields to the test day result resource
  • added a new resource "milkPrediction"
  • added it for the moment in the milk url only

It can be viewed by https://editor.swagger.io/?url=https://raw.githubusercontent.com/adewg/ICAR/erwinspeybroeck/url-schemes/milkURLScheme.json

@cookeac
Copy link
Collaborator

cookeac commented Nov 3, 2022

On 2022-11-03 @erwinspeybroeck took us through the excellent and very interesting API design for this.
We agreed:

  • It would be useful to define a MilkPrediction type which could contain the periodHours (usually 24 hours), and three icarMilkingMilkWeightType objects - one for milkWeight, one for fatWeight, and one for proteinWeight.
  • The names of the predicted average rest of lactation and predicted for next milk recording could then be clearer.

@cookeac cookeac changed the title expected milk yield? Provide predictions for expected milk yield Nov 17, 2022
@cookeac cookeac linked a pull request Nov 17, 2022 that will close this issue
@cookeac cookeac linked a pull request Apr 12, 2023 that will close this issue
@cookeac cookeac closed this as completed Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agenda-next-meeting next-minor-release The issue is not scheduled for the current release, but planned for a release soon after that.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants