Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icarDailyFeedReportCollection refers to non-existing icarDailyFeedReportResource #216

Closed
ahokkonen opened this issue May 19, 2021 · 6 comments
Assignees

Comments

@ahokkonen
Copy link
Contributor

In "collection" folder icarDailyFeedReportCollection refers to non-existing icarDailyFeedReportResource
("$ref": "../resources/icarDailyFeedReportResource.json")

As linter is only checking resources defined in url scheme this issue has "leaked through" :)

We might want to improve spectral checks for all *.json in the project.

@erwinspeybroeck
Copy link
Collaborator

sorry, my fault. We decided not to use icarDailyFeedReportResource and I removed it without thinking about the icarDailyFeedReportCollection - it can also be removed ...

Of course extra check would help to avoid this.

@ahokkonen
Copy link
Contributor Author

I can improve some linter action in my next PR

@erwinspeybroeck
Copy link
Collaborator

should i wait to remove the collection, so we can see your change works?

@ahokkonen
Copy link
Contributor Author

If you want - I can remove it in my PR among other changes (not sure if I'll be able to produce one before tomorrow).
If you don't have some code change already coming from your branch..

@erwinspeybroeck
Copy link
Collaborator

Ok, no problem - you can remove it.

@erwinspeybroeck
Copy link
Collaborator

the unused resource has been removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants