Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing copyright holder in LICENSE #105

Closed
alamers opened this issue May 19, 2020 · 2 comments · Fixed by #106 or #114
Closed

Missing copyright holder in LICENSE #105

alamers opened this issue May 19, 2020 · 2 comments · Fixed by #106 or #114

Comments

@alamers
Copy link
Collaborator

alamers commented May 19, 2020

in our LICENSE file, there is still a placeholder for the copyright holder:
Copyright [yyyy] [name of copyright owner]

I guess this should read
Copyright 2020 ICAR.

Also, it is advised to have a copyright notice in each and every file... I guess that is a bit too much?

@alamers alamers linked a pull request May 19, 2020 that will close this issue
@cookeac
Copy link
Collaborator

cookeac commented May 22, 2020

I had assumed that the bottom section of the LICENCE file described how licence and copyright information should be included into source code or other files, and that the LICENCE file itself should not be edited so that GitHub could recognise it was the standard Apache 2.0 licence.
If that is the case, then that text and link to the licence should be included in the README.md file instead. However, perhaps I misunderstood this!

@alamers
Copy link
Collaborator Author

alamers commented May 22, 2020

I just had a look at (for example) Docker: https://github.com/docker/compose/blob/master/LICENSE

They have done this as well (although I see I forgot to remove the instructional part in the pull request, need to remove that as well).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants