From b46c2b3304349292e79e5847a5e7dfa4dbaa187a Mon Sep 17 00:00:00 2001 From: erwinspeybroeck <47346780+erwinspeybroeck@users.noreply.github.com> Date: Thu, 27 Jun 2019 13:52:46 +0200 Subject: [PATCH 1/3] Update icarMilkingVisitResource.json changed milking Success to Complete and removed the exception codes --- Release Candidate Messages/icarMilkingVisitResource.json | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/Release Candidate Messages/icarMilkingVisitResource.json b/Release Candidate Messages/icarMilkingVisitResource.json index 8957dd5..43a135c 100644 --- a/Release Candidate Messages/icarMilkingVisitResource.json +++ b/Release Candidate Messages/icarMilkingVisitResource.json @@ -29,11 +29,9 @@ "milkingMilkWeight": { "$ref": "icarMilkingMilkWeightType.json" }, - "milkingSuccess": { - "$ref": "icarMilkingSuccessType.json" - }, - "milkingExceptionCode": { - "$ref": "icarMilkingExceptionCode.json" + "milkingComplete": { + "type": "boolean", + "description": "indication whether this milking was completed normally" }, "milkingParlourUnit": { "type": "string", From 52de854551c01fde9fdd377c7d22d878498a03c8 Mon Sep 17 00:00:00 2001 From: erwinspeybroeck <47346780+erwinspeybroeck@users.noreply.github.com> Date: Thu, 27 Jun 2019 13:53:15 +0200 Subject: [PATCH 2/3] Delete icarMilkingExceptionCode.json removed the exception codes --- .../icarMilkingExceptionCode.json | 12 ------------ 1 file changed, 12 deletions(-) delete mode 100644 Release Candidate Messages/icarMilkingExceptionCode.json diff --git a/Release Candidate Messages/icarMilkingExceptionCode.json b/Release Candidate Messages/icarMilkingExceptionCode.json deleted file mode 100644 index 9a9fd01..0000000 --- a/Release Candidate Messages/icarMilkingExceptionCode.json +++ /dev/null @@ -1,12 +0,0 @@ -{ - "type": "string", - "description": "The exception code indicating why the milking was unsuccessfull", - "enum": [ - "0", - "1", - "2", - "3", - "4", - "5" - ] -} From 1750004ed2a3046506574e0baba0f881b940bdac Mon Sep 17 00:00:00 2001 From: erwinspeybroeck <47346780+erwinspeybroeck@users.noreply.github.com> Date: Thu, 27 Jun 2019 13:53:42 +0200 Subject: [PATCH 3/3] Delete icarMilkingSuccessType.json incorparated the definition of this field in the resource definition --- Release Candidate Messages/icarMilkingSuccessType.json | 3 --- 1 file changed, 3 deletions(-) delete mode 100644 Release Candidate Messages/icarMilkingSuccessType.json diff --git a/Release Candidate Messages/icarMilkingSuccessType.json b/Release Candidate Messages/icarMilkingSuccessType.json deleted file mode 100644 index dd97725..0000000 --- a/Release Candidate Messages/icarMilkingSuccessType.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "type": "boolean" -}