From 9fbc4f2eebcd293e5b82db6a1af033f06c7ccc24 Mon Sep 17 00:00:00 2001 From: Arjan Lamers <> Date: Fri, 21 Jun 2019 12:18:32 +0200 Subject: [PATCH 1/6] fixed linting errors, made urls relative, moved url scheme from yaml to json as well --- .../exampleErrorResource.json | 58 +++--- .../exampleUrlScheme.json | 177 ++++++++++++++++++ .../exampleUrlScheme.yaml | 105 ----------- .../icarAnimalIdSchemeCode.json | 4 +- .../icarAnimalIdentifierType.json | 4 +- .../icarMetaDataResource.json | 13 +- .../icarMilkingVisitResource.json | 22 +-- .../icarQuarterMilkingType.json | 8 +- 8 files changed, 237 insertions(+), 154 deletions(-) create mode 100644 Release Candidate Messages/exampleUrlScheme.json delete mode 100644 Release Candidate Messages/exampleUrlScheme.yaml diff --git a/Release Candidate Messages/exampleErrorResource.json b/Release Candidate Messages/exampleErrorResource.json index dd14239..ab2f163 100644 --- a/Release Candidate Messages/exampleErrorResource.json +++ b/Release Candidate Messages/exampleErrorResource.json @@ -1,28 +1,34 @@ { - "id": { - "type": "string", - "description": "A unique identifier for this particular occurrence of the problem" - }, - "status": { - "type": "integer", - "description": "The HTTP status code applicable to this problem, expressed as a string value", - "format": "int32" - }, - "code": { - "type": "string", - "description": "An application-specific error code, expressed as a string value." - }, - "title":{ - "type": "string", - "description": "A short, human-readable summary of the problem that SHOULD NOT change from occurrence to occurrence of the problem, except for purposes of localization." - }, - "detail": { - "type": "string", - "description": "A human-readable explanation specific to this occurrence of the problem. Like title, this field’s value can be localized." - }, - "meta": { - "type": "object", - "properties": "{}" - }, - "description": "A human-readable error message describing what went wrong." + "type": "object", + "properties": { + "id": { + "type": "string", + "description": "A unique identifier for this particular occurrence of the problem" + }, + "status": { + "type": "integer", + "description": "The HTTP status code applicable to this problem, expressed as a string value", + "format": "int32" + }, + "code": { + "type": "string", + "description": "An application-specific error code, expressed as a string value." + }, + "title": { + "type": "string", + "description": "A short, human-readable summary of the problem that SHOULD NOT change from occurrence to occurrence of the problem, except for purposes of localization." + }, + "detail": { + "type": "string", + "description": "A human-readable explanation specific to this occurrence of the problem. Like title, this field’s value can be localized." + }, + "meta": { + "type": "object", + "properties": { + + } + } + }, + "description": "A human-readable error message describing what went wrong." } + diff --git a/Release Candidate Messages/exampleUrlScheme.json b/Release Candidate Messages/exampleUrlScheme.json new file mode 100644 index 0000000..2d562a7 --- /dev/null +++ b/Release Candidate Messages/exampleUrlScheme.json @@ -0,0 +1,177 @@ +{ + "openapi": "3.0.1", + "info": { + "title": "Release Candidate Messages", + "description": "The specifications of messages which are ready for ICAR approval and release", + "version": "1.0", + "contact" : { + "name": "Animal Data Exchange Working Group", + "url": "https://www.icar.org/index.php/technical-bodies/working-groups/animal-data-exchange-wg/", + "email": "icar@icar.org" + } + }, + "servers": [ + { + "url": "http://example.com" + } + ], + "tags" : [ + { + "name" : "release-candidate", + "description" : "approved by the working group, waiting for a test" + } + ], + "paths": { + "/locations/{location-scheme}/{location-id}/milking-visits": { + "get": { + "operationId" : "get-milking-visits", + "summary": "Get the data for milking visits", + "description": "# Purpose\nProvides data from visits of animals to a milking parlour\n", + "tags": [ "release-candidate"], + "parameters": [ + { + "name": "location-scheme", + "in": "path", + "description": "The scheme id for the location identifier.", + "required": true, + "schema": { + "type": "string", + "enum": [ + "nl.ubn", + "de.farmid", + "be.pen" + ] + } + }, + { + "name": "location-id", + "in": "path", + "description": "The unique identifier for the location.", + "required": true, + "schema": { + "type": "string" + } + }, + { + "name": "start-date-time", + "in": "query", + "description": "The start of the date-time range for the data to get in the request.", + "schema": { + "type": "string", + "format": "date-time" + } + }, + { + "name": "end-date-time", + "in": "query", + "description": "The end of the date-time range for the data to get in the request.", + "schema": { + "type": "string", + "format": "date-time" + } + } + ], + "responses": { + "201": { + "description": "Successful. The response contains the milking results for the given location", + "content": { + "application/json": { + "schema": { + "$ref": "#/components/schemas/icarMilkingVisitsResponse" + } + } + } + }, + "default": { + "description": "An error has occured while handling the request. Check the content of the message for the error details.", + "content": { + "application/json": { + "schema": { + "type": "object", + "properties": { + "errors": { + "type": "array", + "items": { + "$ref": "#/components/schemas/error" + } + } + }, + "description": "A default response containing only a list of errors" + } + } + } + } + } + } + } + }, + "components": { + "schemas": { + "responseErrors": { + "type": "object", + "properties": { + "errors": { + "type": "array", + "items": { + "$ref": "#/components/schemas/error" + } + } + } + }, + "responseMetaData": { + "type": "object", + "properties": { + "metaData": { + "$ref": "#/components/schemas/metaData" + } + } + }, + "error": { + "type": "object", + "properties": { + "data": { + "$ref": "exampleErrorResource.json" + } + } + }, + "metaData": { + "required": [ + "source" + ], + "type": "object", + "properties": { + "data": { + "$ref": "icarMetaDataResource.json" + } + } + }, + "icarMilkingVisitsResponse": { + "type": "array", + "items": { + "$ref": "#/components/schemas/icarMilkingVisitsResponseDataSources" + } + }, + "icarMilkingVisitsResponseDataSources": { + "allOf": [ + { + "$ref": "#/components/schemas/responseMetaData" + }, + { + "$ref": "#/components/schemas/responseErrors" + }, + { + "$ref": "#/components/schemas/icarMilkingVisitsResponseDataSource" + } + ] + }, + "icarMilkingVisitsResponseDataSource": { + "type": "object", + "properties": { + "data": { + "$ref": "icarMilkingVisitResource.json" + } + } + } + } + } +} diff --git a/Release Candidate Messages/exampleUrlScheme.yaml b/Release Candidate Messages/exampleUrlScheme.yaml deleted file mode 100644 index 1f470f2..0000000 --- a/Release Candidate Messages/exampleUrlScheme.yaml +++ /dev/null @@ -1,105 +0,0 @@ -openapi: 3.0.1 -info: - title: Release Candidate Messages - description: | - The specifications of messages which are ready for ICAR approval and release - version: '1.0' -servers: - - url: / -paths: - '/locations/{location-scheme}/{location-id}/milking-visits': - get: - summary: Get the data for milking visits - description: | - # Purpose - Provides data from visits of animals to a milking parlour - parameters: - - name: location-scheme - in: path - description: The scheme id for the location identifier. - required: true - schema: - type: string - enum: - - nl.ubn - - de.farmid - - be.pen - - name: location-id - in: path - description: The unique identifier for the location. - required: true - schema: - type: string - - name: start-date-time - in: query - description: The start of the date-time range for the data to get in the request. - schema: - type: string - format: date-time - - name: end-date-time - in: query - description: The end of the date-time range for the data to get in the request. - schema: - type: string - format: date-time - responses: - '201': - description: Successful. The response contains the milking results for the given location - content: - application/json: - schema: - $ref: '#/components/schemas/icarMilkingVisitsResponse' - default: - description: An error has occured while handling the request. Check the content of the message for the error details. - content: - application/json: - schema: - type: object - properties: - errors: - type: array - items: - $ref: '#/components/schemas/error' - description: A default response containing only a list of errors - -components: - schemas: - responseErrors: - type: object - properties: - errors: - type: array - items: - $ref: '#/components/schemas/error' - responseMetaData: - type: object - properties: - metaData: - $ref: '#/components/schemas/metaData' - error: - type: object - properties: - data: - $ref: 'https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/exampleErrorResource.json' - metaData: - required: - - source - type: object - properties: - data: - $ref: 'https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/icarMetaDataResource.json' - icarMilkingVisitsResponse: - type: array - items: - $ref: '#/components/schemas/icarMilkingVisitsResponseDataSources' - icarMilkingVisitsResponseDataSources: - allOf: - - $ref: '#/components/schemas/responseMetaData' - - $ref: '#/components/schemas/responseErrors' - - $ref: '#/components/schemas/icarMilkingVisitsResponseDataSource' - icarMilkingVisitsResponseDataSource: - type: object - properties: - data: - $ref: 'https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/icarMilkingVisitResource.json' - diff --git a/Release Candidate Messages/icarAnimalIdSchemeCode.json b/Release Candidate Messages/icarAnimalIdSchemeCode.json index 127d6c1..c13dc11 100644 --- a/Release Candidate Messages/icarAnimalIdSchemeCode.json +++ b/Release Candidate Messages/icarAnimalIdSchemeCode.json @@ -2,7 +2,7 @@ "type": "string", "description": "Identifies the used scheme for an animal identification string. nl-v1 life numbers are formatted as NL 123456789. See https://www.rvo.nl/onderwerpen/agrarisch-ondernemen/dieren/dieren-registreren/runderen/oormerken-voor-runderen for more information.", "enum": [ - "nl-v1", - "be-v1" + "nl.ubn", + "be.pen" ] } diff --git a/Release Candidate Messages/icarAnimalIdentifierType.json b/Release Candidate Messages/icarAnimalIdentifierType.json index 5a1cd8e..c595bc3 100644 --- a/Release Candidate Messages/icarAnimalIdentifierType.json +++ b/Release Candidate Messages/icarAnimalIdentifierType.json @@ -6,10 +6,10 @@ "type": "object", "properties": { "id": { - "$ref": "https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/icarAnimalIdType.json" + "$ref": "icarAnimalIdType.json" }, "scheme": { - "$ref": "https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/icarAnimalIdSchemeCode.json" + "$ref": "icarAnimalIdSchemeCode.json" } }, "description": "Identifies an animal" diff --git a/Release Candidate Messages/icarMetaDataResource.json b/Release Candidate Messages/icarMetaDataResource.json index c650aff..a587a5b 100644 --- a/Release Candidate Messages/icarMetaDataResource.json +++ b/Release Candidate Messages/icarMetaDataResource.json @@ -1,22 +1,27 @@ { + "type": "object", + "properties": { + "source": { "type": "string", "description": "Source where data is retrieved from. URI that identified the source system" }, "modified": { - "$ref": "https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/icarDateTimeType.json" + "$ref": "icarDateTimeType.json" }, "created": { - "$ref": "https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/icarDateTimeType.json" + "$ref": "icarDateTimeType.json" }, "creator": { "type": "string", "description": "Person or organisation who created the object" }, "validFrom": { - "$ref": "https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/icarDateTimeType.json" + "$ref": "icarDateTimeType.json" }, "validTo": { - "$ref": "https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/icarDateTimeType.json" + "$ref": "icarDateTimeType.json" } + }, + "description": "Generic meta data on this event" } diff --git a/Release Candidate Messages/icarMilkingVisitResource.json b/Release Candidate Messages/icarMilkingVisitResource.json index 6b99780..8f1f82c 100644 --- a/Release Candidate Messages/icarMilkingVisitResource.json +++ b/Release Candidate Messages/icarMilkingVisitResource.json @@ -12,28 +12,28 @@ "description": "A unique identifier for this location for the milking visit message" }, "animal": { - "$ref": "https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/icarAnimalIdentifierType.json" + "$ref": "icarAnimalIdentifierType.json" }, "milkingStartingDateTime": { - "$ref": "https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/icarDateTimeType.json" + "$ref": "icarDateTimeType.json" }, "milkingDuration": { - "$ref": "https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/icarMilkDurationType.json" + "$ref": "icarMilkDurationType.json" }, "milkingVisitDuration": { - "$ref": "https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/icarMilkDurationType.json" + "$ref": "icarMilkDurationType.json" }, "milkingType": { - "$ref": "https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/icarMilkingTypeCode.json" + "$ref": "icarMilkingTypeCode.json" }, "milkingMilkWeight": { - "$ref": "https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/icarMilkingMilkWeightType.json" + "$ref": "icarMilkingMilkWeightType.json" }, "milkingSuccess": { - "$ref": "https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/icarMilkingSuccessType.json" + "$ref": "icarMilkingSuccessType.json" }, "milkingExceptionCode": { - "$ref": "https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/icarMilkingExceptionCode.json" + "$ref": "icarMilkingExceptionCode.json" }, "milkingParlourUnit": { "type": "string", @@ -54,19 +54,19 @@ "quarterMilkings": { "type": "array", "items": { - "$ref": "https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/icarQuarterMilkingType.json" + "$ref": "icarQuarterMilkingType.json" } }, "animalMilkingSample": { "type": "array", "items": { - "$ref": "https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/icarAnimalMilkingSampleType.json" + "$ref": "icarAnimalMilkingSampleType.json" } }, "icarMilkCharacteristicsTypes": { "type": "array", "items": { - "$ref": "https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/icarMilkCharacteristicsType.json" + "$ref": "icarMilkCharacteristicsType.json" } } } diff --git a/Release Candidate Messages/icarQuarterMilkingType.json b/Release Candidate Messages/icarQuarterMilkingType.json index f0c437b..50d2f15 100644 --- a/Release Candidate Messages/icarQuarterMilkingType.json +++ b/Release Candidate Messages/icarQuarterMilkingType.json @@ -11,21 +11,21 @@ "RB" ] }, "quarterMilkingDuration": { - "$ref": "https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/icarMilkDurationType.json" + "$ref": "icarMilkDurationType.json" }, "quarterMilkingWeight": { - "$ref": "https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/icarMilkingMilkWeightType.json" + "$ref": "icarMilkingMilkWeightType.json" }, "icarQuarterMilkingSample": { "type": "array", "items": { - "$ref": "https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/icarQuarterMilkingSampleType.json" + "$ref": "icarQuarterMilkingSampleType.json" } }, "icarQuarterCharacteristics": { "type": "array", "items": { - "$ref": "https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/icarMilkCharacteristicsType.json" + "$ref": "icarMilkCharacteristicsType.json" } } } From 733d3310fa06f34e771f64e6f10f35319dfef8ee Mon Sep 17 00:00:00 2001 From: Arjan Lamers <> Date: Thu, 27 Jun 2019 08:47:10 +0200 Subject: [PATCH 2/6] fixed broken link due to renaming yaml to json --- README.md | 4 ++-- Using the standard.md | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 9d02ef6..219fcac 100644 --- a/README.md +++ b/README.md @@ -3,9 +3,9 @@ This repository contains the ICAR ADE work-in-progress JSON standard. This page describes the principles driving this standard. If you want to use the ICAR ADE standard in your application, there are tips and tricks in the [Using the standard](https://github.com/adewg/ICAR/blob/master/Using%20the%20standard.md) file. For a quick start, open the -[exampleUrlScheme.yaml](https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/exampleUrlScheme.yaml) file in +[exampleUrlScheme.yaml](https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/exampleUrlScheme.json) file in your favorite OpenAPI Specification editor, or use the following URL to have a preview in the free Redoc tool: [view -exampleUrlScheme.yaml](https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/exampleUrlScheme.yaml) +exampleUrlScheme.yaml](https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/exampleUrlScheme.json) Approach diff --git a/Using the standard.md b/Using the standard.md index 054c53a..31e014d 100644 --- a/Using the standard.md +++ b/Using the standard.md @@ -6,10 +6,10 @@ The ADE standard is meant to be an open standard. As such, you are free to start The standard currently focuses on JSON messages defined in JSON Schema. These messages can be transported via REST or via any other channel. We are also working on a recommended URL scheme if you want to use REST. For now, you can find an example URL scheme to help you navigate and decide how to use the standard. This scheme is defined in the OpenAPI Specification v3. ## Getting Started -Most developers should be familiar with REST and JSON files. To simply view the standard, you can open the [exampleUrlScheme.yaml](https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/exampleUrlScheme.yaml) file in your favorite OpenAPI Specification editor. +Most developers should be familiar with REST and JSON files. To simply view the standard, you can open the [exampleUrlScheme.yaml](https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/exampleUrlScheme.json) file in your favorite OpenAPI Specification editor. Or, for convenience, use the following URL to have a preview in the free Redoc tool: -[view exampleUrlScheme.yaml](https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/exampleUrlScheme.yaml) +[view exampleUrlScheme.json](https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/exampleUrlScheme.json) ## Customizing the Standard The standard aims to cover most cases in a generic way. However, there will always be regional differences or vendor specific fields that may be required to be part of a message. You are free to simply add more fields to your messages than described in the standard. When doing so, please take note of the following recommendations: From dab66ba8181e59c5b7c0ffe4cb90f83e321e3756 Mon Sep 17 00:00:00 2001 From: Arjan Lamers <> Date: Thu, 27 Jun 2019 08:48:49 +0200 Subject: [PATCH 3/6] fixed broken link due to renaming yaml to json, missed a few --- README.md | 4 ++-- Using the standard.md | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 219fcac..c3181ab 100644 --- a/README.md +++ b/README.md @@ -3,9 +3,9 @@ This repository contains the ICAR ADE work-in-progress JSON standard. This page describes the principles driving this standard. If you want to use the ICAR ADE standard in your application, there are tips and tricks in the [Using the standard](https://github.com/adewg/ICAR/blob/master/Using%20the%20standard.md) file. For a quick start, open the -[exampleUrlScheme.yaml](https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/exampleUrlScheme.json) file in +[exampleUrlScheme.json](https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/exampleUrlScheme.json) file in your favorite OpenAPI Specification editor, or use the following URL to have a preview in the free Redoc tool: [view -exampleUrlScheme.yaml](https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/exampleUrlScheme.json) +exampleUrlScheme.json](https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/exampleUrlScheme.json) Approach diff --git a/Using the standard.md b/Using the standard.md index 31e014d..0cede4e 100644 --- a/Using the standard.md +++ b/Using the standard.md @@ -6,7 +6,7 @@ The ADE standard is meant to be an open standard. As such, you are free to start The standard currently focuses on JSON messages defined in JSON Schema. These messages can be transported via REST or via any other channel. We are also working on a recommended URL scheme if you want to use REST. For now, you can find an example URL scheme to help you navigate and decide how to use the standard. This scheme is defined in the OpenAPI Specification v3. ## Getting Started -Most developers should be familiar with REST and JSON files. To simply view the standard, you can open the [exampleUrlScheme.yaml](https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/exampleUrlScheme.json) file in your favorite OpenAPI Specification editor. +Most developers should be familiar with REST and JSON files. To simply view the standard, you can open the [exampleUrlScheme.json](https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/exampleUrlScheme.json) file in your favorite OpenAPI Specification editor. Or, for convenience, use the following URL to have a preview in the free Redoc tool: [view exampleUrlScheme.json](https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/adewg/ICAR/master/Release%20Candidate%20Messages/exampleUrlScheme.json) From b46c2b3304349292e79e5847a5e7dfa4dbaa187a Mon Sep 17 00:00:00 2001 From: erwinspeybroeck <47346780+erwinspeybroeck@users.noreply.github.com> Date: Thu, 27 Jun 2019 13:52:46 +0200 Subject: [PATCH 4/6] Update icarMilkingVisitResource.json changed milking Success to Complete and removed the exception codes --- Release Candidate Messages/icarMilkingVisitResource.json | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/Release Candidate Messages/icarMilkingVisitResource.json b/Release Candidate Messages/icarMilkingVisitResource.json index 8957dd5..43a135c 100644 --- a/Release Candidate Messages/icarMilkingVisitResource.json +++ b/Release Candidate Messages/icarMilkingVisitResource.json @@ -29,11 +29,9 @@ "milkingMilkWeight": { "$ref": "icarMilkingMilkWeightType.json" }, - "milkingSuccess": { - "$ref": "icarMilkingSuccessType.json" - }, - "milkingExceptionCode": { - "$ref": "icarMilkingExceptionCode.json" + "milkingComplete": { + "type": "boolean", + "description": "indication whether this milking was completed normally" }, "milkingParlourUnit": { "type": "string", From 52de854551c01fde9fdd377c7d22d878498a03c8 Mon Sep 17 00:00:00 2001 From: erwinspeybroeck <47346780+erwinspeybroeck@users.noreply.github.com> Date: Thu, 27 Jun 2019 13:53:15 +0200 Subject: [PATCH 5/6] Delete icarMilkingExceptionCode.json removed the exception codes --- .../icarMilkingExceptionCode.json | 12 ------------ 1 file changed, 12 deletions(-) delete mode 100644 Release Candidate Messages/icarMilkingExceptionCode.json diff --git a/Release Candidate Messages/icarMilkingExceptionCode.json b/Release Candidate Messages/icarMilkingExceptionCode.json deleted file mode 100644 index 9a9fd01..0000000 --- a/Release Candidate Messages/icarMilkingExceptionCode.json +++ /dev/null @@ -1,12 +0,0 @@ -{ - "type": "string", - "description": "The exception code indicating why the milking was unsuccessfull", - "enum": [ - "0", - "1", - "2", - "3", - "4", - "5" - ] -} From 1750004ed2a3046506574e0baba0f881b940bdac Mon Sep 17 00:00:00 2001 From: erwinspeybroeck <47346780+erwinspeybroeck@users.noreply.github.com> Date: Thu, 27 Jun 2019 13:53:42 +0200 Subject: [PATCH 6/6] Delete icarMilkingSuccessType.json incorparated the definition of this field in the resource definition --- Release Candidate Messages/icarMilkingSuccessType.json | 3 --- 1 file changed, 3 deletions(-) delete mode 100644 Release Candidate Messages/icarMilkingSuccessType.json diff --git a/Release Candidate Messages/icarMilkingSuccessType.json b/Release Candidate Messages/icarMilkingSuccessType.json deleted file mode 100644 index dd97725..0000000 --- a/Release Candidate Messages/icarMilkingSuccessType.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "type": "boolean" -}