CDATA error with partial update

[thombergs]

Reported by rmillet42, Apr 11, 2014
What steps will reproduce the problem?

1. Use wicked-charts-jsf21 with JSF ajax partial update

What is the expected output? What do you see instead?
CDATA is not encoded in the response, breaking it.

What version of the product are you using? On what operating system?
Wicked-charts revision 303 (1.5.1-SNAPSHOT)
Mojarra 2.2.6
Tomcat 7

Attached a patch working with my settings (not tested with other JSF implementations) of wicked-charts-jsf21/src/main/java/com/googlecode/wickedcharts/jsf21/UIChart.java

Index: src/main/java/com/googlecode/wickedcharts/jsf21/UIChart.java
===================================================================
--- src/main/java/com/googlecode/wickedcharts/jsf21/UIChart.java    (revision 303)
+++ src/main/java/com/googlecode/wickedcharts/jsf21/UIChart.java    (working copy)
@@ -44,9 +44,6 @@
    private Theme theme;
    private String themeUrlRef;

-   private final static String PRE_JS = "\n<script type=\"text/javascript\">\n/*<![CDATA[*/\n$(function() {\n";
-   private final static String POST_JS = "\n;});\n/*]]>*/\n</script>";
-
    private static final Feature[] SUPPORTED_FEATURES = new Feature[] {

    };
@@ -81,13 +78,19 @@
        // include Theme JS
        this.addThemeJavaScript(writer, renderer);

-       writer.append(UIChart.PRE_JS);
-       // include Chart JS
-       writer.append(MessageFormat.format(
-               "var {0} = {1};\nvar {2} = new Highcharts.Chart({0});",
-               optionsVarname, renderer.toJson(options), chartVarname));
+       StringBuffer sb = new StringBuffer(512);
+       sb.append("//<![CDATA[\n");
+       sb.append("$(function() {\n");
+       sb.append(MessageFormat.format(
+                        "var {0} = {1};\nvar {2} = new Highcharts.Chart({0});",
+                        optionsVarname, renderer.toJson(options), chartVarname));
+       sb.append("\n;});\n");
+       sb.append("//]]>\n");

-       writer.append(UIChart.POST_JS);
+       writer.startElement("script", this);
+       writer.writeAttribute("type", "text/javascript", "type");
+       writer.writeText(sb.toString(), this, null);
+       writer.endElement("script");
    }

    private void addThemeJavaScript(ResponseWriter writer, JsonRenderer renderer)
@@ -101,11 +104,19 @@
                            this.getThemeUrlRef()));

        } else if (this.getTheme() != null) {
-           writer.append(UIChart.PRE_JS);
-           writer.append(MessageFormat.format("Highcharts.setOptions({0})",
-                   renderer.toJson(this.getTheme())));
-           writer.append(UIChart.POST_JS);

+           StringBuffer sb = new StringBuffer(512);
+           sb.append("//<![CDATA[\n");
+           sb.append("$(function() {\n");
+           sb.append(MessageFormat.format("Highcharts.setOptions({0})",
+                                                renderer.toJson(this.getTheme())));
+           sb.append("\n;});\n");
+           sb.append("//]]>\n");
+
+           writer.startElement("script", this);
+           writer.writeAttribute("type", "text/javascript", "type");
+           writer.writeText(sb.toString(), this, null);
+           writer.endElement("script");
        }
    }