Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try using iframe instead of opening a new tab #2

Open
himanshub16 opened this issue Aug 12, 2016 · 3 comments
Open

Try using iframe instead of opening a new tab #2

himanshub16 opened this issue Aug 12, 2016 · 3 comments

Comments

@himanshub16
Copy link

Open the playlist in an iframe and give a button to open in a new tab.

@adeora7 adeora7 closed this as completed Aug 13, 2016
@adeora7 adeora7 reopened this Aug 13, 2016
@adeora7
Copy link
Owner

adeora7 commented Aug 13, 2016

Right now, the idea doesn't sound good, although can give an option in next edition

@hackedhacker
Copy link

I'd like to add to this idea, if you want to use an iframe, try using the embeded version of the video.
The difference is quite small.

Here is an example (just in-case you didn't know, which I hope isn't true and you actually know already) :
Opening in tab, would require the following url => https://www.youtube.com/watch?v=JGwWNGJdvx8
But adding an embeded version uses the url => https://www.youtube.com/embed/JGwWNGJdvx8

Basically its https://www.youtube.com/watch?v=[VIDEO_CODE] changed to https://www.youtube.com/embed/[VIDEO_CODE]

And I agree with this idea, because it doesn't add to the tab, and you could actually add the embed player on a div that you didn't show.

And adding more, since I believe you'd require the embed video to auto play, add ?autoplay=1 at the end of the url. (source:https://stackoverflow.com/questions/7281765/youtube-iframe-embed-auto-play)

@adeora7
Copy link
Owner

adeora7 commented Jul 15, 2017

@hackedhacker the implementation isn't the question for now. I am not really sure if iframe should be used or not. Because I look at this extension as just a controller for youtube and not a youtube player. So I don't see the benefits of using iframe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants