Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Yarn Berry v3 upgrade #1734

Closed
mrtnzlml opened this issue Feb 5, 2021 · 2 comments · Fixed by #2154
Closed

Investigate Yarn Berry v3 upgrade #1734

mrtnzlml opened this issue Feb 5, 2021 · 2 comments · Fixed by #2154
Assignees
Labels
help wanted Extra attention is needed

Comments

@mrtnzlml
Copy link
Member

mrtnzlml commented Feb 5, 2021

Seems like it should be possible now. I'd suggest going through the migration guide, open a draft PR, and start modifying the tooling where necessary (src/monorepo-utils/src/getWorkspaceDependencies.js for example). Feel free to open a new discussion for it.

Please note: we should think about backward compatibility when doing these changes.

Alternatives

@mrtnzlml mrtnzlml added the help wanted Extra attention is needed label Feb 5, 2021
@tbergquist-godaddy
Copy link
Contributor

What is our long-term plan here, is it to stay with yarn-workspaces, or use bazel?

Because bazel does not really supporting yarn workspaces, but might do so in the future. See bazel-contrib/rules_nodejs#266

I am just thinking is it worth it going to yarn berry if we want to migrate to bazel, or will we stay with a dual sort of pipeline until bazel fully supports yarn workspaces?

@mrtnzlml
Copy link
Member Author

I'd say long long term Bazel and before that Yarn. We are not progressing with the Bazel thingy very much so who knows what is the timeline here.

@mrtnzlml mrtnzlml changed the title Investigate Yarn Berry upgrade Investigate Yarn Berry v3 upgrade Apr 12, 2021
@mrtnzlml mrtnzlml self-assigned this Sep 7, 2021
@kodiakhq kodiakhq bot closed this as completed in #2154 Mar 7, 2022
adeira-github-bot pushed a commit to adeira/abacus-backoffice that referenced this issue Mar 7, 2022
See: https://yarnpkg.com/getting-started/migration

Closes: adeira/universe#1734

adeira-source-id: 682c74f1255a02a10653c8f4b790b7c8ad8612f8
adeira-github-bot pushed a commit to mrtnzlml-archive/kochka.com.mx that referenced this issue Mar 7, 2022
See: https://yarnpkg.com/getting-started/migration

Closes: adeira/universe#1734

adeira-source-id: 682c74f1255a02a10653c8f4b790b7c8ad8612f8
adeira-github-bot pushed a commit to adeira/abacus-kochka that referenced this issue Mar 7, 2022
See: https://yarnpkg.com/getting-started/migration

Closes: adeira/universe#1734

adeira-source-id: 682c74f1255a02a10653c8f4b790b7c8ad8612f8
adeira-github-bot pushed a commit to adeira/sx-tailwind-website that referenced this issue Mar 7, 2022
See: https://yarnpkg.com/getting-started/migration

Closes: adeira/universe#1734

adeira-source-id: 682c74f1255a02a10653c8f4b790b7c8ad8612f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants