Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include option is not working #163

Closed
carpusmedia opened this issue Aug 23, 2016 · 1 comment
Closed

include option is not working #163

carpusmedia opened this issue Aug 23, 2016 · 1 comment

Comments

@carpusmedia
Copy link

Hello,

Thank you for a great module.

It seems like the include option is not working for some reason (critical-0.7.3).

This is our code:

    return critical.generate({
        base: 'dist/',
        url : 'http://example.com',
        src: 'http:///example.com',
        dest: 'src/assets/scss/critical-path-styles.css',
        css: ['dist/assets/css/app.css'],
        width: 1300,
        height: 900,
        inline: false,
        include: ['html.test'],
        minify: false
    }); 

critical-path-styles.css contains all styles needed to render the above-the-fold content, however it does not include the html.test selector styles.

Using html instead of html.test does work however.

Are others experiencing this issue as well?

Thank you

@carpusmedia
Copy link
Author

Strange, re-ordered a few things in the CSS file, now html.test as a selector seems to work fine as well.

Was a problem on our end.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant