Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using gulp 4 #141

Closed
sp90 opened this issue May 26, 2016 · 1 comment
Closed

When using gulp 4 #141

sp90 opened this issue May 26, 2016 · 1 comment

Comments

@sp90
Copy link

sp90 commented May 26, 2016

In there i have critical to run over all my html files and optimize my css files.

But i just swapped to gulp 4, and it now throws this err

The following tasks did not complete: deploy, html--deploy
Did you forget to signal async completion?

var critical = require('critical').stream;

gulp.task('html--deploy', function() {
    return gulp.src(config.html)
        .pipe(critical({base: 'dist/', inline: true, css: ['dist/css/app.css']}))
        .pipe(gulp.dest('dist'));
});

Could it be the ('critical').stream?

@sp90 sp90 closed this as completed May 26, 2016
@sp90
Copy link
Author

sp90 commented May 26, 2016

Wasn't critical sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant