Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing black-check.yml to remove traiting whitespace #143

Closed
wants to merge 1 commit into from

Conversation

mohmmadAyesh
Copy link

Hi I added a black-check workflow that check formatting code when doing a pull request I hope you accept it it is part of solving Fixes #134

@mohmmadAyesh
Copy link
Author

@adbar HI can you check this PR and merge it if it doesnt need any further changes

@adbar
Copy link
Owner

adbar commented Apr 2, 2024

Hi @mohmmadAyesh, I don't exactly understand what your PR does, in any case it does not fix #134, e.g. by adding a requirements-dev.txt file.

@mohmmadAyesh
Copy link
Author

It provide a github action check the formatting code style using black package if it doesnt fix #134 please tell me what require from me to fix it

@mohmmadAyesh
Copy link
Author

I added a github workflow that check coding style using black package when a new PR is opened

@adbar
Copy link
Owner

adbar commented Apr 3, 2024

I updated the description in #134, please follow the steps indicated there if you want to draft a pull request.

Black is already part of the CI/CD on Github workflows so the current PR doesn't fix anything IMO.

@adbar adbar closed this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dev requirements
2 participants