Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aria-description #3642

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Add aria-description #3642

merged 1 commit into from
Nov 22, 2024

Conversation

amanmahajan7
Copy link
Contributor

@amanmahajan7 amanmahajan7 self-assigned this Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.63%. Comparing base (e79641b) to head (4768c96).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3642      +/-   ##
==========================================
- Coverage   89.71%   89.63%   -0.09%     
==========================================
  Files          48       48              
  Lines        3453     3455       +2     
  Branches      648      652       +4     
==========================================
- Hits         3098     3097       -1     
- Misses        355      358       +3     
Files with missing lines Coverage Δ
src/DataGrid.tsx 86.13% <100.00%> (+4.95%) ⬆️

... and 4 files with indirect coverage changes

---- 🚨 Try these New Features:

@amanmahajan7 amanmahajan7 marked this pull request as ready for review November 22, 2024 18:54
Copy link
Contributor

@nstepien nstepien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to do the same for TreeDataGrid?

@amanmahajan7 amanmahajan7 merged commit 041357f into main Nov 22, 2024
3 checks passed
@amanmahajan7 amanmahajan7 deleted the am-aria-description branch November 22, 2024 19:02
@amanmahajan7
Copy link
Contributor Author

amanmahajan7 commented Nov 22, 2024

It forwards the props so should be good. I can add a test in the next PR

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants