Migrate more test to use vitest-browser-react and browserUserEvent
#3633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3633 +/- ##
==========================================
+ Coverage 89.83% 91.65% +1.82%
==========================================
Files 48 48
Lines 3453 3453
Branches 655 680 +25
==========================================
+ Hits 3102 3165 +63
+ Misses 351 288 -63
|
nstepien
approved these changes
Nov 18, 2024
| @@ -10,6 +10,6 @@ test('key is escaped in query selectors', () => { | |||
| ]; | |||
|
|
|||
| expect(() => { | |||
| setup({ columns, rows: [] }); | |||
| setupNew({ columns, rows: [] }); | |||
| }).not.toThrow(); | |||
There was a problem hiding this comment.
Does it throw if we don't escape the key?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.