Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 16 support #1232

Closed
3 of 11 tasks
pie6k opened this issue Jun 25, 2018 · 2 comments
Closed
3 of 11 tasks

React 16 support #1232

pie6k opened this issue Jun 25, 2018 · 2 comments

Comments

@pie6k
Copy link

pie6k commented Jun 25, 2018

Spent 20+ hours trying to figure out

Error: Invariant Violation: Failed exporting HTML for URL / (XYZ): Element type is invalid: expected a string (for built-in components) or a class/  function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default   and named imports.

when trying to build website with react-static only to realize react-data-grid is not supporting React 16.

It should be red-text'ed on main readme as first line of text. Damn I'm angry!

Reproduce:

  1. Use react-static
  2. Create any project with react-static create
  3. Add react-data-grid
  4. Use it in any form
  5. Try to run production build (it works in dev build! SIC!) with react-static build

Expected result:
Build works as in development mode

Actual result:
react-data-grid is breaking the build silently with error message as above. Removing all instances of react-data-grid useage makes build work again. Note react-static is based on React 16+.


Which version of React JS are you using?

✅ Officially supported ✅

  • v15.4.x

⚠️ Not officially supported, expect warnings ⚠️

  • v15.5.x
  • v15.6.x

☣️ Not officially supported, expect warnings and errors ☣️

  • v16.x.x!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

Which browser are you using?

✅ Officially supported ✅

  • IE 9 / IE 10 / IE 11
  • Edge
  • Chrome

⚠️ Not officially supported, but "should work" ⚠️

  • Firefox
  • Safari

I'm submitting a ...

  • 🐛 Bug Report
  • 💡 Feature Request

👋 Need general support? Not sure about how to use React itself, or how to get started with the Grid?
Please do not submit support request here. Instead see

https://github.com/adazzle/react-data-grid/blob/master/CONTRIBUTING.md


@colindjk
Copy link
Contributor

According the the changelog, there should already be support for React 16 as of react-data-grid 4.0.7, as mentioned in this issue #1116.

I assume you tried building without react-data-grid and it worked, are you sure the issue is not react-static itself?

@malonecj
Copy link
Contributor

Hi
Yes ReactDataGrid is React 16 compatible as of version 4. I believe your issue is with React static integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants