Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected cell outline not fully visible in IE11 #1216

Closed
3 of 11 tasks
lexanth opened this issue May 29, 2018 · 2 comments
Closed
3 of 11 tasks

Selected cell outline not fully visible in IE11 #1216

lexanth opened this issue May 29, 2018 · 2 comments
Labels

Comments

@lexanth
Copy link

lexanth commented May 29, 2018

Which version of React JS are you using?

✅ Officially supported ✅

  • v15.4.x

⚠️ Not officially supported, expect warnings ⚠️

  • v15.5.x
  • v15.6.x

☣️ Not officially supported, expect warnings and errors ☣️

  • v16.x.x

Which browser are you using?

✅ Officially supported ✅

  • IE 9 / IE 10 / IE 11
  • Edge
  • Chrome

⚠️ Not officially supported, but "should work" ⚠️

  • Firefox
  • Safari

I'm submitting a ...

  • 🐛 Bug Report
  • 💡 Feature Request

Issue Details

Open the examples in IE11 (11.0.9600.19002)
Open an example with selectable cells
Select a cell

On e.g. chrome, the cell selection outline looks right. On IE11, only the top and left outlines are visible.

Also, the selected cell loses all outline while being dragged down (cell drag down example), and the highlight doesn't seem to be visible until the drag and drop is released.

I've added z-index: 10 to .react-grid-Cell:focus which seems to sort the first issue.

@amanmahajan7
Copy link
Contributor

amanmahajan7 commented Jun 6, 2018

Cell drag does not work in IE11 due the way HTML5 drag and drop works in IE 11 but this will be fix in this PR. We recently merged a PR that improves cell rendering logic and will fix this particular issue. It is a big rewrite and we discovered a few bugs during internal testing. This is being actively worked on but at this moment we do not know when this will be released.

@stale
Copy link

stale bot commented Jul 12, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please reopen this if you feel it has been incorrectly closed and we will do our best to look into it. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 12, 2018
@stale stale bot closed this as completed Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants