Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Add _theme and _menu attributes to config.json (fixes #3602) #3610

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Fix: Add _theme and _menu attributes to config.json (fixes #3602) #3610

merged 1 commit into from
Oct 15, 2024

Conversation

swashbuck
Copy link
Contributor

Fix #3602

Fix

  • Adds _theme and _menu attributes to config.json. Without these, courses can break when importing into AAT v1.

@swashbuck swashbuck added the bug label Oct 2, 2024
@swashbuck swashbuck self-assigned this Oct 2, 2024
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

kirsty-hames
kirsty-hames approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit 23512c6 into master Oct 15, 2024
2 checks passed
@oliverfoster oliverfoster deleted the issue/3602 branch October 15, 2024 14:22
github-actions bot pushed a commit that referenced this pull request Oct 15, 2024
@semantic-release-bot
Chore(release): 5.41.6 [skip ci]
aea6cb6 
## [5.41.6](v5.41.5...v5.41.6) (2024-10-15)

### Fix

* Add _theme and _menu attributes to config.json (#3610) ([23512c6](23512c6)), closes [#3610](#3610)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 5.41.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

Assignees

@swashbuck swashbuck

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AAT: Add _theme and _menu properties to sample course
4 participants
@swashbuck @kirsty-hames @oliverfoster @cahirodoherty-learningpool