Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Corrected _completionCriteria values to match defaults (fixes … #3488

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Fix: Corrected _completionCriteria values to match defaults (fixes … #3488

merged 1 commit into from
Dec 6, 2023

Conversation

danielghost
Copy link
Contributor

Fixes #3375.

Fix

  • Corrected _completionCriteria values to match defaults.

@danielghost danielghost added the bug label Dec 4, 2023
@danielghost danielghost self-assigned this Dec 4, 2023
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit bf18c57 into master Dec 6, 2023
3 checks passed
@oliverfoster oliverfoster deleted the issue/3375 branch December 6, 2023 10:01
github-actions bot pushed a commit that referenced this pull request Dec 6, 2023
@semantic-release-bot
Chore(release): 5.33.9 [skip ci]
8a42b29 
## [5.33.9](v5.33.8...v5.33.9) (2023-12-06)

### Fix

* Corrected `_completionCriteria` values to match defaults (fixes #3375). (#3488) ([bf18c57](bf18c57)), closes [#3375](#3375) [#3488](#3488)
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

🎉 This PR is included in version 5.33.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eleanor-heath eleanor-heath eleanor-heath approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

Assignees

@danielghost danielghost

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update config.json to include ability to trigger tracking:complete for every assessment attempt
4 participants
@danielghost @oliverfoster @cahirodoherty-learningpool @eleanor-heath